Rules removed before Comment Rules begin (#1072)

Author: Dylan203

examples/graphql_example/src/Plugin/GraphQL/DataProducer/QueryArticles.php

@@ -77,8 +77,8 @@ public function __construct(
   }
 
   /**
-   * @param $offset
-   * @param $limit
+   * @param int $offset
+   * @param int $limit
    * @param \Drupal\Core\Cache\RefinableCacheableDependencyInterface $metadata
    *
    * @return \Drupal\graphql_examples\Wrappers\QueryConnection

phpcs.xml.dist

@@ -10,9 +10,7 @@
     <exclude name="Drupal.Commenting.ClassComment.Missing"/>
     <exclude name="Drupal.Commenting.DocComment.MissingShort"/>
     <exclude name="Drupal.Commenting.FunctionComment.MissingParamComment"/>
-    <exclude name="Drupal.Commenting.FunctionComment.MissingParamType"/>
     <exclude name="Drupal.Commenting.FunctionComment.MissingReturnComment"/>
-    <exclude name="Drupal.Commenting.FunctionComment.InvalidNoReturn"/>
   </rule>
 
 </ruleset>

src/Annotation/DataProducer.php

@@ -37,13 +37,13 @@ class DataProducer extends Plugin {
   /**
    * DataProducer constructor.
    *
-   * @param $values
+   * @param array $values
    *   The plugin annotation values.
    *
    * @throws \Doctrine\Common\Annotations\AnnotationException
    *   In case of missing required annotation values.
    */
-  public function __construct($values) {
+  public function __construct(array $values) {
     if (!array_key_exists('id', $values) || !$values['id']) {
       throw new AnnotationException('The plugin is missing an "id" property.');
     }

src/Annotation/PersistedQuery.php

@@ -37,13 +37,13 @@ class PersistedQuery extends Plugin {
   /**
    * PersistedQuery constructor.
    *
-   * @param $values
+   * @param array $values
    *   The plugin annotation values.
    *
    * @throws \Doctrine\Common\Annotations\AnnotationException
    *   In case of missing required annotation values.
    */
-  public function __construct($values) {
+  public function __construct(array $values) {
     if (!array_key_exists('id', $values) || !$values['id']) {
       throw new AnnotationException('The plugin is missing an "id" property.');
     }

src/GraphQL/Buffers/BufferBase.php

@@ -138,9 +138,6 @@ protected function resolveBuffer(\SplObjectStorage $buffer) {
    *
    * @param array $buffer
    *   The buffer as an array.
-   *
-   * @return array
-   *   The resolved results, keyed by their corresponding buffer item array key.
    */
   protected function resolveBufferArray(array $buffer) {
     throw new \LogicException('Method not implemented.');

src/GraphQL/Execution/Executor.php

@@ -113,10 +113,10 @@ class Executor implements ExecutorImplementation {
    * @param \GraphQL\Type\Schema $schema
    * @param \GraphQL\Language\AST\DocumentNode $document
    * @param \Drupal\graphql\GraphQL\Execution\ResolveContext $context
-   * @param $root
-   * @param $variables
-   * @param $operation
-   * @param $resolver
+   * @param mixed $root
+   * @param mixed $variables
+   * @param string $operation
+   * @param callable $resolver
    */
   public function __construct(
     CacheContextsManager $contextsManager,
@@ -130,7 +130,7 @@ public function __construct(
     $root,
     $variables,
     $operation,
-    $resolver
+    callable $resolver
   ) {
     $this->contextsManager = $contextsManager;
     $this->cacheBackend = $cacheBackend;
@@ -153,10 +153,10 @@ public function __construct(
    * @param \GraphQL\Type\Schema $schema
    * @param \GraphQL\Language\AST\DocumentNode $document
    * @param \Drupal\graphql\GraphQL\Execution\ResolveContext $context
-   * @param $root
-   * @param $variables
-   * @param $operation
-   * @param $resolver
+   * @param mixed $root
+   * @param mixed $variables
+   * @param string $operation
+   * @param callable $resolver
    *
    * @return \Drupal\graphql\GraphQL\Execution\Executor
    */
@@ -169,7 +169,7 @@ public static function create(
     $root,
     $variables,
     $operation,
-    $resolver
+    callable $resolver
   ) {
     return new static(
       $container->get('cache_contexts_manager'),

src/GraphQL/Execution/ExecutorFactory.php

@@ -27,10 +27,10 @@ public function __construct(ContainerInterface $container) {
    * @param \GraphQL\Executor\Promise\PromiseAdapter $adapter
    * @param \GraphQL\Type\Schema $schema
    * @param \GraphQL\Language\AST\DocumentNode $document
-   * @param $root
+   * @param mixed $root
    * @param \Drupal\graphql\GraphQL\Execution\ResolveContext $context
-   * @param $variables
-   * @param $operation
+   * @param mixed $variables
+   * @param string $operation
    * @param callable $resolver
    *
    * @return \Drupal\graphql\GraphQL\Execution\Executor

src/GraphQL/Execution/FieldContext.php

@@ -46,7 +46,7 @@ public function getContextLanguage() {
   }
 
   /**
-   * @param $language
+   * @param string $language
    *
    * @return $this
    */
@@ -63,7 +63,7 @@ public function setContextLanguage($language) {
    *
    * @param string $name
    *   The name of the context.
-   * @param $value
+   * @param mixed $value
    *   The value of the context.
    *
    * @return $this

src/GraphQL/Execution/ResolveContext.php

@@ -53,7 +53,7 @@ class ResolveContext implements RefinableCacheableDependencyInterface {
    * @param \Drupal\graphql\Entity\ServerInterface $server
    * @param \GraphQL\Server\OperationParams $operation
    * @param \GraphQL\Language\AST\DocumentNode $document
-   * @param $type
+   * @param string $type
    * @param array $config
    */
   public function __construct(
@@ -108,9 +108,9 @@ public function getContextLanguage() {
   }
 
   /**
-   * @param $language
+   * @param string $language
    *
-   * @return string
+   * @return $this
    */
   public function setContextLanguage($language) {
     $this->language = $language;
@@ -127,7 +127,7 @@ public function setContextLanguage($language) {
    *   The resolve info object.
    * @param string $name
    *   The name of the context.
-   * @param $value
+   * @param mixed $value
    *   The value of the context.
    *
    * @return $this

src/GraphQL/Resolver/Argument.php

@@ -18,7 +18,7 @@ class Argument implements ResolverInterface {
   /**
    * Argument constructor.
    *
-   * @param $name
+   * @param string $name
    */
   public function __construct($name) {
     $this->name = $name;