style(phpcs): Update Coder to 8.3.10 and fix warnings (#1078)

Author: klausi

.travis.yml

@@ -91,7 +91,7 @@ install:
   - composer --no-interaction --working-dir=$DRUPAL_BUILD_DIR run-script drupal-phpunit-upgrade
 
   # Install PHPCS to check for Drupal coding standards.
-  - travis_retry composer global require drupal/coder:8.3.9
+  - travis_retry composer global require drupal/coder:8.3.10
   - $HOME/.composer/vendor/bin/phpcs --config-set installed_paths $HOME/.composer/vendor/drupal/coder/coder_sniffer
 
 script:

src/Controller/ServerListBuilder.php

@@ -7,7 +7,7 @@
 use Drupal\Core\Url;
 
 /**
- * Class ServerListBuilder.
+ * Admin page controller that shows the list of configured GraphQL servers.
  *
  * @package Drupal\graphql\Controller
  *

src/Entity/Server.php

@@ -157,7 +157,10 @@ public function id() {
    */
   public function executeOperation(OperationParams $operation) {
     $previous = Executor::getImplementationFactory();
-    Executor::setImplementationFactory([\Drupal::service('graphql.executor'), 'create']);
+    Executor::setImplementationFactory([
+      \Drupal::service('graphql.executor'),
+      'create',
+    ]);
 
     try {
       $config = $this->configuration();
@@ -402,7 +405,7 @@ public function getPersistedQueryInstances() {
       return $this->persisted_query_instances;
     }
 
-    /* @var \Drupal\graphql\Plugin\PersistedQueryPluginManager $plugin_manager */
+    /** @var \Drupal\graphql\Plugin\PersistedQueryPluginManager $plugin_manager */
     $plugin_manager = \Drupal::service('plugin.manager.graphql.persisted_query');
     $definitions = $plugin_manager->getDefinitions();
     $persisted_queries_settings = $this->get('persisted_queries_settings');

src/Form/PersistedQueriesForm.php

@@ -48,7 +48,7 @@ public function getFormId() {
   public function form(array $form, FormStateInterface $form_state) {
     $form = parent::form($form, $form_state);
 
-    /* @var PersistedQueryPluginInterface[] $plugins */
+    /** @var PersistedQueryPluginInterface[] $plugins */
     $plugins = $this->entity->getPersistedQueryInstances();
     $all_plugins = $this->getAllPersistedQueryPlugins();
     $form['#tree'] = TRUE;

src/Form/ServerForm.php

@@ -143,7 +143,7 @@ public function form(array $form, FormStateInterface $formState) {
       '#tree' => TRUE,
     ];
 
-    /* @var \Drupal\graphql\Plugin\SchemaPluginInterface $instance */
+    /** @var \Drupal\graphql\Plugin\SchemaPluginInterface $instance */
     $instance = $schema ? $this->schemaManager->createInstance($schema) : NULL;
     if ($instance instanceof PluginFormInterface && $instance instanceof ConfigurableInterface) {
       $instance->setConfiguration($server->get('schema_configuration')[$schema] ?? []);
@@ -218,7 +218,7 @@ public function validateForm(array &$form, FormStateInterface $formState) {
       $formState->setErrorByName('endpoint', 'The endpoint path contains invalid characters.');
     }
 
-    /* @var \Drupal\graphql\Plugin\SchemaPluginInterface $instance */
+    /** @var \Drupal\graphql\Plugin\SchemaPluginInterface $instance */
     $schema = $formState->getValue('schema');
     $instance = $this->schemaManager->createInstance($schema);
     if (!empty($form['schema_configuration'][$schema]) && $instance instanceof PluginFormInterface && $instance instanceof ConfigurableInterface) {
@@ -233,7 +233,7 @@ public function validateForm(array &$form, FormStateInterface $formState) {
   public function submitForm(array &$form, FormStateInterface $formState) {
     parent::submitForm($form, $formState);
 
-    /* @var \Drupal\graphql\Plugin\SchemaPluginInterface $instance */
+    /** @var \Drupal\graphql\Plugin\SchemaPluginInterface $instance */
     $schema = $formState->getValue('schema');
     $instance = $this->schemaManager->createInstance($schema);
     if ($instance instanceof PluginFormInterface && $instance instanceof ConfigurableInterface) {

src/GraphQL/ResolverRegistry.php

@@ -54,8 +54,14 @@ class ResolverRegistry implements ResolverRegistryInterface {
    * @param callable|null $defaultTypeResolver
    */
   public function __construct(callable $defaultFieldResolver = NULL, callable $defaultTypeResolver = NULL) {
-    $this->defaultFieldResolver = $defaultFieldResolver ?: [$this, 'resolveFieldDefault'];
-    $this->defaultTypeResolver = $defaultTypeResolver ?: [$this, 'resolveTypeDefault'];
+    $this->defaultFieldResolver = $defaultFieldResolver ?: [
+      $this,
+      'resolveFieldDefault',
+    ];
+    $this->defaultTypeResolver = $defaultTypeResolver ?: [
+      $this,
+      'resolveTypeDefault',
+    ];
   }
 
   /**

src/Plugin/GraphQL/DataProducer/DataProducerPluginBase.php

@@ -42,7 +42,10 @@ public function resolveField(FieldContext $field) {
 
     // TODO: The field context should probably be the first argument.
     $context = $this->getContextValues();
-    return call_user_func_array([$this, 'resolve'], array_merge($context, [$field]));
+    return call_user_func_array(
+      [$this, 'resolve'],
+      array_merge($context, [$field])
+    );
   }
 
 }

src/Plugin/GraphQL/DataProducer/Entity/EntityLoad.php

@@ -169,7 +169,7 @@ public function resolve($type, $id, $language, ?array $bundles, ?bool $access, ?
       // Check if the passed user (or current user if none is passed) has access
       // to the entity, if not return NULL.
       if ($access) {
-        /* @var $accessResult \Drupal\Core\Access\AccessResultInterface */
+        /** @var \Drupal\Core\Access\AccessResultInterface $accessResult */
         $accessResult = $entity->access($accessOperation, $accessUser, TRUE);
         $context->addCacheableDependency($accessResult);
         if (!$accessResult->isAllowed()) {

src/Plugin/GraphQL/DataProducer/Entity/EntityLoadByUuid.php

@@ -169,7 +169,7 @@ public function resolve($type, $uuid, $language, $bundles, ?bool $access, ?Accou
       // Check if the passed user (or current user if none is passed) has access
       // to the entity, if not return NULL.
       if ($access) {
-        /* @var $accessResult \Drupal\Core\Access\AccessResultInterface */
+        /** @var \Drupal\Core\Access\AccessResultInterface $accessResult */
         $accessResult = $entity->access($accessOperation, $accessUser, TRUE);
         $context->addCacheableDependency($accessResult);
         if (!$accessResult->isAllowed()) {

src/Plugin/GraphQL/DataProducer/Entity/EntityLoadMultiple.php

@@ -169,7 +169,7 @@ public function resolve($type, array $ids, $language, ?array $bundles, bool $acc
         }
 
         if ($access) {
-          /* @var $accessResult \Drupal\Core\Access\AccessResultInterface */
+          /** @var \Drupal\Core\Access\AccessResultInterface $accessResult */
           $accessResult = $entities[$id]->access($accessOperation, $accessUser, TRUE);
           $context->addCacheableDependency($accessResult);
           // We need to call isAllowed() because isForbidden() returns FALSE