fix(executor): Remove swapped errors compatibility mode

Author: klausi

config/install/graphql.settings.yml

@@ -1,12 +1,3 @@
-graphql.settings:
-  type: config_object
-  label: "GraphQL Settings"
-  mapping:
-    deprecated_swap_errors_and_extensions_in_results:
-      type: boolean
-      label: "Return `errors` in the GraphQL response `extension` key and vice versa"
-      description: "Preserves behaviour that was caused by a bug that caused errors to appear in the extensions key of GraphQL results. Ensures misbehaving client implementations don't break by fixing this bug. Will be removed in 5.0.0"
-
 graphql.graphql_servers.*:
   type: config_entity
   label: 'Server'

config/schema/graphql.schema.yml

@@ -65,10 +65,7 @@ function graphql_update_8001(): void {
 }
 
 /**
- * Preserve incorrect error reporting behaviour for PR #1161.
+ * Empty update that was removed again.
  */
 function graphql_update_8400() :void {
-  \Drupal::configFactory()->getEditable('graphql.settings')
-    ->set('deprecated_swap_errors_and_extensions_in_results', TRUE)
-    ->save();
 }

graphql.install

@@ -223,13 +223,7 @@ public function doExecute(): Promise {
     return $this->doExecuteUncached()->then(function ($result) {
       $this->context->mergeCacheMaxAge(0);
 
-      // @todo keep only else case in 5.0.0.
-      if (\Drupal::config('graphql.settings')->get('deprecated_swap_errors_and_extensions_in_results')) {
-        $result = new CacheableExecutionResult($result->data, $result->extensions, $result->errors);
-      }
-      else {
-        $result = new CacheableExecutionResult($result->data, $result->errors, $result->extensions);
-      }
+      $result = new CacheableExecutionResult($result->data, $result->errors, $result->extensions);
       $result->addCacheableDependency($this->context);
       return $result;
     });
@@ -252,13 +246,7 @@ protected function doExecuteCached($prefix) {
         $this->context->mergeCacheMaxAge(0);
       }
 
-      // @todo keep only else case in 5.0.0.
-      if (\Drupal::config('graphql.settings')->get('deprecated_swap_errors_and_extensions_in_results')) {
-        $result = new CacheableExecutionResult($result->data, $result->extensions, $result->errors);
-      }
-      else {
-        $result = new CacheableExecutionResult($result->data, $result->errors, $result->extensions);
-      }
+      $result = new CacheableExecutionResult($result->data, $result->errors, $result->extensions);
       $result->addCacheableDependency($this->context);
       if ($result->getCacheMaxAge() !== 0) {
         $this->cacheWrite($prefix, $result);