Skip to content

Commit 070e5f7

Browse files
benpeartgitster
authored andcommitted
convert: remove erroneous tests for errno == EPIPE
start_multi_file_filter() and apply_multi_file_filter() currently test for errno == EPIPE but treating EPIPE as an error is already happening from one of the packet_write() functions. Signed-off-by: Ben Peart <benpeart@microsoft.com> Found/Fixed-by: Jeff King <peff@peff.net> Acked-by: Lars Schneider <larsxschneider@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent e1104a5 commit 070e5f7

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

convert.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -661,7 +661,7 @@ static struct cmd2process *start_multi_file_filter(struct hashmap *hashmap, cons
661661
done:
662662
sigchain_pop(SIGPIPE);
663663

664-
if (err || errno == EPIPE) {
664+
if (err) {
665665
error("initialization for external filter '%s' failed", cmd);
666666
kill_multi_file_filter(hashmap, entry);
667667
return NULL;
@@ -752,7 +752,7 @@ static int apply_multi_file_filter(const char *path, const char *src, size_t len
752752
done:
753753
sigchain_pop(SIGPIPE);
754754

755-
if (err || errno == EPIPE) {
755+
if (err) {
756756
if (!strcmp(filter_status.buf, "error")) {
757757
/* The filter signaled a problem with the file. */
758758
} else if (!strcmp(filter_status.buf, "abort")) {

0 commit comments

Comments
 (0)