Skip to content

Commit 1fd365d

Browse files
committed
Merge branch 'cc/no-gitk-build-dependency'
Remove leftover bits from an earlier change to move gitk in its own subdirectory. Reimplementing the dependency tracking rules needs to be done in gitk history separately. * cc/no-gitk-build-dependency: Makefile: replace "echo 1>..." with "echo >..." Makefile: detect when PYTHON_PATH changes Makefile: remove tracking of TCLTK_PATH
2 parents 4f43e97 + 1a59d88 commit 1fd365d

2 files changed

Lines changed: 14 additions & 15 deletions

File tree

.gitignore

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
/GIT-BUILD-OPTIONS
22
/GIT-CFLAGS
33
/GIT-LDFLAGS
4-
/GIT-GUI-VARS
54
/GIT-PREFIX
5+
/GIT-PYTHON-VARS
66
/GIT-SCRIPT-DEFINES
77
/GIT-USER-AGENT
88
/GIT-VERSION-FILE
@@ -171,7 +171,6 @@
171171
/git-whatchanged
172172
/git-write-tree
173173
/git-core-*/?*
174-
/gitk-git/gitk-wish
175174
/gitweb/GITWEB-BUILD-OPTIONS
176175
/gitweb/gitweb.cgi
177176
/gitweb/static/gitweb.js

Makefile

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2221,7 +2221,7 @@ endef
22212221
GIT-SCRIPT-DEFINES: FORCE
22222222
@FLAGS='$(SCRIPT_DEFINES)'; \
22232223
if test x"$$FLAGS" != x"`cat $@ 2>/dev/null`" ; then \
2224-
echo 1>&2 " * new script parameters"; \
2224+
echo >&2 " * new script parameters"; \
22252225
echo "$$FLAGS" >$@; \
22262226
fi
22272227

@@ -2283,7 +2283,7 @@ $(patsubst %.perl,%,$(SCRIPT_PERL)) git-instaweb: % : unimplemented.sh
22832283
endif # NO_PERL
22842284

22852285
ifndef NO_PYTHON
2286-
$(patsubst %.py,%,$(SCRIPT_PYTHON)): GIT-CFLAGS GIT-PREFIX
2286+
$(patsubst %.py,%,$(SCRIPT_PYTHON)): GIT-CFLAGS GIT-PREFIX GIT-PYTHON-VARS
22872287
$(patsubst %.py,%,$(SCRIPT_PYTHON)): % : %.py
22882288
$(QUIET_GEN)$(RM) $@ $@+ && \
22892289
INSTLIBDIR=`MAKEFLAGS= $(MAKE) -C git_remote_helpers -s \
@@ -2602,7 +2602,7 @@ TRACK_PREFIX = $(bindir_SQ):$(gitexecdir_SQ):$(template_dir_SQ):$(prefix_SQ):\
26022602
GIT-PREFIX: FORCE
26032603
@FLAGS='$(TRACK_PREFIX)'; \
26042604
if test x"$$FLAGS" != x"`cat GIT-PREFIX 2>/dev/null`" ; then \
2605-
echo 1>&2 " * new prefix flags"; \
2605+
echo >&2 " * new prefix flags"; \
26062606
echo "$$FLAGS" >GIT-PREFIX; \
26072607
fi
26082608

@@ -2611,7 +2611,7 @@ TRACK_CFLAGS = $(CC):$(subst ','\'',$(ALL_CFLAGS)):$(USE_GETTEXT_SCHEME)
26112611
GIT-CFLAGS: FORCE
26122612
@FLAGS='$(TRACK_CFLAGS)'; \
26132613
if test x"$$FLAGS" != x"`cat GIT-CFLAGS 2>/dev/null`" ; then \
2614-
echo 1>&2 " * new build flags"; \
2614+
echo >&2 " * new build flags"; \
26152615
echo "$$FLAGS" >GIT-CFLAGS; \
26162616
fi
26172617

@@ -2620,7 +2620,7 @@ TRACK_LDFLAGS = $(subst ','\'',$(ALL_LDFLAGS))
26202620
GIT-LDFLAGS: FORCE
26212621
@FLAGS='$(TRACK_LDFLAGS)'; \
26222622
if test x"$$FLAGS" != x"`cat GIT-LDFLAGS 2>/dev/null`" ; then \
2623-
echo 1>&2 " * new link flags"; \
2623+
echo >&2 " * new link flags"; \
26242624
echo "$$FLAGS" >GIT-LDFLAGS; \
26252625
fi
26262626

@@ -2662,14 +2662,14 @@ ifdef GIT_PERF_MAKE_OPTS
26622662
@echo GIT_PERF_MAKE_OPTS=\''$(subst ','\'',$(subst ','\'',$(GIT_PERF_MAKE_OPTS)))'\' >>$@
26632663
endif
26642664

2665-
### Detect Tck/Tk interpreter path changes
2666-
ifndef NO_TCLTK
2667-
TRACK_VARS = $(subst ','\'',-DTCLTK_PATH='$(TCLTK_PATH_SQ)')
2665+
### Detect Python interpreter path changes
2666+
ifndef NO_PYTHON
2667+
TRACK_PYTHON = $(subst ','\'',-DPYTHON_PATH='$(PYTHON_PATH_SQ)')
26682668

2669-
GIT-GUI-VARS: FORCE
2670-
@VARS='$(TRACK_VARS)'; \
2669+
GIT-PYTHON-VARS: FORCE
2670+
@VARS='$(TRACK_PYTHON)'; \
26712671
if test x"$$VARS" != x"`cat $@ 2>/dev/null`" ; then \
2672-
echo 1>&2 " * new Tcl/Tk interpreter location"; \
2672+
echo >&2 " * new Python interpreter location"; \
26732673
echo "$$VARS" >$@; \
26742674
fi
26752675
endif
@@ -2948,8 +2948,8 @@ ifndef NO_TCLTK
29482948
$(MAKE) -C gitk-git clean
29492949
$(MAKE) -C git-gui clean
29502950
endif
2951-
$(RM) GIT-VERSION-FILE GIT-CFLAGS GIT-LDFLAGS GIT-GUI-VARS GIT-BUILD-OPTIONS
2952-
$(RM) GIT-USER-AGENT GIT-PREFIX GIT-SCRIPT-DEFINES
2951+
$(RM) GIT-VERSION-FILE GIT-CFLAGS GIT-LDFLAGS GIT-BUILD-OPTIONS
2952+
$(RM) GIT-USER-AGENT GIT-PREFIX GIT-SCRIPT-DEFINES GIT-PYTHON-VARS
29532953

29542954
.PHONY: all install profile-clean clean strip
29552955
.PHONY: shell_compatibility_test please_set_SHELL_PATH_to_a_more_modern_shell

0 commit comments

Comments
 (0)