janitor: useless checks before free

MadCoder · gitster · commit 24deea527370 · 2009-07-22T21:57:41.000-07:00
Signed-off-by: Pierre Habouzit &lt;madcoder@debian.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/pack-revindex.c b/pack-revindex.c
@@ -149,8 +149,7 @@ void discard_revindex(void)
 	if (pack_revindex_hashsz) {
 		int i;
 		for (i = 0; i < pack_revindex_hashsz; i++)
-			if (pack_revindex[i].revindex)
-				free(pack_revindex[i].revindex);
+			free(pack_revindex[i].revindex);
 		free(pack_revindex);
 		pack_revindex_hashsz = 0;
 	}
diff --git a/walker.c b/walker.c
@@ -245,7 +245,7 @@ void walker_targets_free(int targets, char **target, const char **write_ref)
 {
 	while (targets--) {
 		free(target[targets]);
-		if (write_ref && write_ref[targets])
+		if (write_ref)
 			free((char *) write_ref[targets]);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ void walker_targets_free(int targets, char target, const char write_ref)`
`245`	`245`	`{`
`246`	`246`	`while (targets--) {`
`247`	`247`	`free(target[targets]);`
`248`		`- if (write_ref && write_ref[targets])`
	`248`	`+ if (write_ref)`
`249`	`249`	`free((char *) write_ref[targets]);`
`250`	`250`	`}`
`251`	`251`	`}`