Skip to content

Commit 24e7a5b

Browse files
committed
Merge branch 'jc/diff-merge-base-multi'
* jc/diff-merge-base-multi: diff A...B: do not limit the syntax too narrowly
2 parents 7ea3ddf + 7a0e4d7 commit 24e7a5b

1 file changed

Lines changed: 0 additions & 13 deletions

File tree

builtin/diff.c

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -408,19 +408,6 @@ int cmd_diff(int argc, const char **argv, const char *prefix)
408408
else if (ents == 2)
409409
result = builtin_diff_tree(&rev, argc, argv, ent);
410410
else if (ent[0].item->flags & UNINTERESTING) {
411-
/*
412-
* Perhaps the user gave us A...B, which expands
413-
* to a list of negative merge bases followed by
414-
* A (symmetric-left) and B? Let's make sure...
415-
*/
416-
for (i = 1; i < ents; i++)
417-
if (!(ent[i].item->flags & UNINTERESTING))
418-
break;
419-
if (ents != i + 2 ||
420-
(ent[i+1].item->flags & UNINTERESTING) ||
421-
(!(ent[i].item->flags & SYMMETRIC_LEFT)) ||
422-
(ent[i+1].item->flags & SYMMETRIC_LEFT))
423-
die("what do you mean by that?");
424411
/*
425412
* diff A...B where there is at least one merge base
426413
* between A and B. We have ent[0] == merge-base,

0 commit comments

Comments
 (0)