Skip to content

Commit 53350a3

Browse files
peffgitster
authored andcommitted
t: avoid using ":" for comments
The ":" is not a comment marker, but rather a noop command. Using it as a comment like: : do something cmd1 && : something else cmd2 breaks the &&-chain, and we would fail to notice if "cmd1" failed in this instance. We can just use regular "#" comments instead. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 9ddc5ac commit 53350a3

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

t/t4104-apply-boundary.sh

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ test_expect_success setup '
1818
cat victim >original &&
1919
git update-index --add victim &&
2020
21-
: add to the head
21+
# add to the head
2222
for i in a b '"$L"' y
2323
do
2424
echo $i
@@ -27,7 +27,7 @@ test_expect_success setup '
2727
git diff victim >add-a-patch.with &&
2828
git diff --unified=0 >add-a-patch.without &&
2929
30-
: insert at line two
30+
# insert at line two
3131
for i in b a '"$L"' y
3232
do
3333
echo $i
@@ -36,7 +36,7 @@ test_expect_success setup '
3636
git diff victim >insert-a-patch.with &&
3737
git diff --unified=0 >insert-a-patch.without &&
3838
39-
: modify at the head
39+
# modify at the head
4040
for i in a '"$L"' y
4141
do
4242
echo $i
@@ -45,16 +45,16 @@ test_expect_success setup '
4545
git diff victim >mod-a-patch.with &&
4646
git diff --unified=0 >mod-a-patch.without &&
4747
48-
: remove from the head
48+
# remove from the head
4949
for i in '"$L"' y
5050
do
5151
echo $i
5252
done >victim &&
5353
cat victim >del-a-expect &&
54-
git diff victim >del-a-patch.with
54+
git diff victim >del-a-patch.with &&
5555
git diff --unified=0 >del-a-patch.without &&
5656
57-
: add to the tail
57+
# add to the tail
5858
for i in b '"$L"' y z
5959
do
6060
echo $i
@@ -63,7 +63,7 @@ test_expect_success setup '
6363
git diff victim >add-z-patch.with &&
6464
git diff --unified=0 >add-z-patch.without &&
6565
66-
: modify at the tail
66+
# modify at the tail
6767
for i in b '"$L"' z
6868
do
6969
echo $i
@@ -72,7 +72,7 @@ test_expect_success setup '
7272
git diff victim >mod-z-patch.with &&
7373
git diff --unified=0 >mod-z-patch.without &&
7474
75-
: remove from the tail
75+
# remove from the tail
7676
for i in b '"$L"'
7777
do
7878
echo $i
@@ -81,7 +81,7 @@ test_expect_success setup '
8181
git diff victim >del-z-patch.with &&
8282
git diff --unified=0 >del-z-patch.without
8383
84-
: done
84+
# done
8585
'
8686

8787
for with in with without

t/t5533-push-cas.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ setup_srcdst_basic () {
1414
}
1515

1616
test_expect_success setup '
17-
: create template repository
17+
# create template repository
1818
test_commit A &&
1919
test_commit B &&
2020
test_commit C

0 commit comments

Comments
 (0)