send-email: send_message die on $!, not $?

avar · gitster · commit 5e2c2ab1599f · 2010-09-30T12:20:33.000-07:00
If close fails we want to emit errno, not the return code of whatever
happened to be the child process run.

Signed-off-by: Ævar Arnfjörð Bjarmason &lt;avarab@gmail.comReviewed-by: Avery Pennarun &lt;apenwarr@gmail.com&gt;
Reviewed-by: Jeff King &lt;peff@peff.net&gt;
&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/git-send-email.perl b/git-send-email.perl
@@ -1035,7 +1035,7 @@ sub send_message {
 			exec($smtp_server, @sendmail_parameters) or die $!;
 		}
 		print $sm "$header\n$message";
-		close $sm or die $?;
+		close $sm or die $!;
 	} else {
 
 		if (!defined $smtp_server) {

Original file line number	Diff line number	Diff line change
`@@ -1035,7 +1035,7 @@ sub send_message {`
`1035`	`1035`	`exec($smtp_server, @sendmail_parameters) or die $!;`
`1036`	`1036`	`}`
`1037`	`1037`	`print $sm "$header\n$message";`
`1038`		`- close $sm or die $?;`
	`1038`	`+ close $sm or die $!;`
`1039`	`1039`	`} else {`
`1040`	`1040`
`1041`	`1041`	`if (!defined $smtp_server) {`