Skip to content

Commit 63296d5

Browse files
committed
Merge branch 'jc/refer-to-t-readme-from-submitting-patches'
* jc/refer-to-t-readme-from-submitting-patches: t/README: justify why "! grep foo" is sufficient SubmittingPatches: refer to t/README for tests
2 parents 168ab99 + 53de742 commit 63296d5

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

Documentation/SubmittingPatches

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ change, the approach taken by the change, and if relevant how this
5757
differs substantially from the prior version, are all good things
5858
to have.
5959

60-
Make sure that you have tests for the bug you are fixing.
60+
Make sure that you have tests for the bug you are fixing. See
61+
t/README for guidance.
6162

6263
When adding a new feature, make sure that you have new tests to show
6364
the feature triggers the new behaviour when it should, and to show the

t/README

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,8 @@ Don't:
418418
dies in an unexpected way (e.g. segfault).
419419

420420
On the other hand, don't use test_must_fail for running regular
421-
platform commands; just use '! cmd'.
421+
platform commands; just use '! cmd'. We are not in the business
422+
of verifying that the world given to us sanely works.
422423

423424
- use perl without spelling it as "$PERL_PATH". This is to help our
424425
friends on Windows where the platform Perl often adds CR before

0 commit comments

Comments
 (0)