exclude_existing(): set existing_refs.strdup_strings

mhagger · gitster · commit 66ce0366285f · 2013-06-02T15:28:47.000-07:00
The each_ref_fn add_existing() adds refnames to the existing_refs
list.  But the lifetimes of these refnames is not guaranteed by the
refs API, so configure the string_list to make copies as it adds them.

Signed-off-by: Michael Haggerty &lt;mhagger@alum.mit.edu&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/show-ref.c b/builtin/show-ref.c
@@ -103,7 +103,7 @@ static int add_existing(const char *refname, const unsigned char *sha1, int flag
  */
 static int exclude_existing(const char *match)
 {
-	static struct string_list existing_refs = STRING_LIST_INIT_NODUP;
+	static struct string_list existing_refs = STRING_LIST_INIT_DUP;
 	char buf[1024];
 	int matchlen = match ? strlen(match) : 0;
 

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ static int add_existing(const char refname, const unsigned char sha1, int flag`
`103`	`103`	`*/`
`104`	`104`	`static int exclude_existing(const char *match)`
`105`	`105`	`{`
`106`		`- static struct string_list existing_refs = STRING_LIST_INIT_NODUP;`
	`106`	`+ static struct string_list existing_refs = STRING_LIST_INIT_DUP;`
`107`	`107`	`char buf[1024];`
`108`	`108`	`int matchlen = match ? strlen(match) : 0;`
`109`	`109`