imap-send: check NULL return of SSL_CTX_new()

rhenium · gitster · commit 6738a33b3102 · 2016-04-08T11:46:22.000-07:00
SSL_CTX_new() may fail with return value NULL.

Signed-off-by: Kazuki Yamaguchi &lt;k@rhe.jp&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/imap-send.c b/imap-send.c
@@ -298,6 +298,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve
 	}
 
 	ctx = SSL_CTX_new(meth);
+	if (!ctx) {
+		ssl_socket_perror("SSL_CTX_new");
+		return -1;
+	}
 
 	if (verify)
 		SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER, NULL);

Original file line number	Diff line number	Diff line change
`@@ -298,6 +298,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve`
`298`	`298`	`}`
`299`	`299`
`300`	`300`	`ctx = SSL_CTX_new(meth);`
	`301`	`+ if (!ctx) {`
	`302`	`+ ssl_socket_perror("SSL_CTX_new");`
	`303`	`+ return -1;`
	`304`	`+ }`
`301`	`305`
`302`	`306`	`if (verify)`
`303`	`307`	`SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER, NULL);`