Skip to content

Commit 681390b

Browse files
seveaspeff
authored andcommitted
t5813: avoid creating urls that break on cygwin
When passed an ssh:// url, git strips ssh://host from the url but does not remove leading slashes from the path. So when this test used ssh://remote//path/to/pwd, the path accessed by our fake SSH is //path/to/pwd, which cygwin interprets as a UNC path, causing the test to fail. We may want to actually fix this in git itself, making it remove extra slashes from urls before feeding them to transports or helpers, but that's for another topic as it could cause regressions. Signed-off-by: Dennis Kaarsemaker <dennis@kaarsemaker.net> Signed-off-by: Jeff King <peff@peff.net>
1 parent af40944 commit 681390b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

t/t5813-proto-disable-ssh.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ test_expect_success 'setup repository to clone' '
1414
'
1515

1616
test_proto "host:path" ssh "remote:repo.git"
17-
test_proto "ssh://" ssh "ssh://remote/$PWD/remote/repo.git"
18-
test_proto "git+ssh://" ssh "git+ssh://remote/$PWD/remote/repo.git"
17+
test_proto "ssh://" ssh "ssh://remote$PWD/remote/repo.git"
18+
test_proto "git+ssh://" ssh "git+ssh://remote$PWD/remote/repo.git"
1919

2020
test_done

0 commit comments

Comments
 (0)