abbrev_sha1_in_line: don't leak memory

stefanbeller · gitster · commit 6eb6078bf5fd · 2016-04-01T10:32:43.000-07:00
`split` is of type `struct strbuf **`, and currently we are leaking split
itself as well as each element in split[i]. We have a dedicated free
function for `struct strbuf **`, which takes care of freeing all
related memory.

Helped-by: Eric Sunshine &lt;sunshine@sunshineco.com&gt;
Signed-off-by: Stefan Beller &lt;sbeller@google.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/wt-status.c b/wt-status.c
@@ -1063,9 +1063,7 @@ static void abbrev_sha1_in_line(struct strbuf *line)
 				strbuf_addf(line, "%s", split[i]->buf);
 		}
 	}
-	for (i = 0; split[i]; i++)
-		strbuf_release(split[i]);
-
+	strbuf_list_free(split);
 }
 
 static void read_rebase_todolist(const char *fname, struct string_list *lines)

Original file line number	Diff line number	Diff line change
`@@ -1063,9 +1063,7 @@ static void abbrev_sha1_in_line(struct strbuf *line)`
`1063`	`1063`	`strbuf_addf(line, "%s", split[i]->buf);`
`1064`	`1064`	`}`
`1065`	`1065`	`}`
`1066`		`- for (i = 0; split[i]; i++)`
`1067`		`- strbuf_release(split[i]);`
`1068`		`-`
	`1066`	`+ strbuf_list_free(split);`
`1069`	`1067`	`}`
`1070`	`1068`
`1071`	`1069`	`static void read_rebase_todolist(const char fname, struct string_list lines)`