perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}

chriscool · gitster · commit 6f5ecad6a556 · 2018-01-05T12:31:07.000-08:00
The way we check ENV{GIT_PERF_SUBSECTION} could trigger
comparison between undef and "" that may be flagged by
use of strict &amp; warnings. Let's fix that.

Signed-off-by: Christian Couder &lt;chriscool@tuxfamily.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl
@@ -70,7 +70,7 @@ sub format_times {
 }
 
 my $resultsdir = "test-results";
-if ($ENV{GIT_PERF_SUBSECTION} ne "") {
+if (exists $ENV{GIT_PERF_SUBSECTION} and $ENV{GIT_PERF_SUBSECTION} ne "") {
 	$resultsdir .= "/" . $ENV{GIT_PERF_SUBSECTION};
 }
 

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ sub format_times {`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`my $resultsdir = "test-results";`
`73`		`-if ($ENV{GIT_PERF_SUBSECTION} ne "") {`
	`73`	`+if (exists $ENV{GIT_PERF_SUBSECTION} and $ENV{GIT_PERF_SUBSECTION} ne "") {`
`74`	`74`	`$resultsdir .= "/" . $ENV{GIT_PERF_SUBSECTION};`
`75`	`75`	`}`
`76`	`76`