Skip to content

Commit 796b137

Browse files
committed
Merge branch 'maint'
* maint: Start 1.6.2.3 preparation process_{tree,blob}: Remove useless xstrdup calls git-pull.sh: better warning message for "git pull" on detached head. Conflicts: RelNotes
2 parents 6da14ee + db12d97 commit 796b137

5 files changed

Lines changed: 53 additions & 25 deletions

File tree

Documentation/RelNotes-1.6.2.3.txt

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
GIT v1.6.2.3 Release Notes
2+
==========================
3+
4+
Fixes since v1.6.2.2
5+
--------------------
6+
7+
* Setting an octal mode value to core.sharedrepository configuration to
8+
restrict access to the repository to group members did not work as
9+
advertised.
10+
11+
* A fairly large and trivial memory leak while rev-list shows list of
12+
reachable objects has been identified and plugged.
13+
14+
* "git-commit --interactive" did not abort when underlying "git-add -i"
15+
signaled a failure.
16+
17+
* git-repack (invoked from git-gc) did not work as nicely as it should in
18+
a repository that borrows objects from neighbours via alternates
19+
mechanism especially when some packs are marked with the ".keep" flag
20+
to prevent them from being repacked.
21+
22+
Many small documentation updates are included as well.
23+
24+
---
25+
exec >/var/tmp/1
26+
echo O=$(git describe maint)
27+
O=v1.6.2.2-41-gbff82d0
28+
git shortlog --no-merges $O..maint

Documentation/RelNotes-1.6.3.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,6 @@ Updates since v1.6.2
105105

106106
* Output from git-remote command has been vastly improved.
107107

108-
* git-repack (invoked from git-gc) did not work as nicely as it should in
109-
a repository that borrows objects from neighbours via alternates
110-
mechanism especially when some packs are marked with the ".keep" flag
111-
to prevent them from being repacked.
112-
113108
* git-send-email learned --confirm option to review the Cc: list before
114109
sending the messages out.
115110

git-pull.sh

Lines changed: 25 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -90,23 +90,31 @@ error_on_no_merge_candidates () {
9090

9191
curr_branch=${curr_branch#refs/heads/}
9292

93-
echo "You asked me to pull without telling me which branch you"
94-
echo "want to merge with, and 'branch.${curr_branch}.merge' in"
95-
echo "your configuration file does not tell me either. Please"
96-
echo "name which branch you want to merge on the command line and"
97-
echo "try again (e.g. 'git pull <repository> <refspec>')."
98-
echo "See git-pull(1) for details on the refspec."
99-
echo
100-
echo "If you often merge with the same branch, you may want to"
101-
echo "configure the following variables in your configuration"
102-
echo "file:"
103-
echo
104-
echo " branch.${curr_branch}.remote = <nickname>"
105-
echo " branch.${curr_branch}.merge = <remote-ref>"
106-
echo " remote.<nickname>.url = <url>"
107-
echo " remote.<nickname>.fetch = <refspec>"
108-
echo
109-
echo "See git-config(1) for details."
93+
if [ -z "$curr_branch" ]; then
94+
echo "You are not currently on a branch, so I cannot use any"
95+
echo "'branch.<branchname>.merge' in your configuration file."
96+
echo "Please specify which branch you want to merge on the command"
97+
echo "line and try again (e.g. 'git pull <repository> <refspec>')."
98+
echo "See git-pull(1) for details."
99+
else
100+
echo "You asked me to pull without telling me which branch you"
101+
echo "want to merge with, and 'branch.${curr_branch}.merge' in"
102+
echo "your configuration file does not tell me either. Please"
103+
echo "specify which branch you want to merge on the command line and"
104+
echo "try again (e.g. 'git pull <repository> <refspec>')."
105+
echo "See git-pull(1) for details."
106+
echo
107+
echo "If you often merge with the same branch, you may want to"
108+
echo "configure the following variables in your configuration"
109+
echo "file:"
110+
echo
111+
echo " branch.${curr_branch}.remote = <nickname>"
112+
echo " branch.${curr_branch}.merge = <remote-ref>"
113+
echo " remote.<nickname>.url = <url>"
114+
echo " remote.<nickname>.fetch = <refspec>"
115+
echo
116+
echo "See git-config(1) for details."
117+
fi
110118
exit 1
111119
}
112120

list-objects.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ static void process_blob(struct rev_info *revs,
2323
if (obj->flags & (UNINTERESTING | SEEN))
2424
return;
2525
obj->flags |= SEEN;
26-
name = xstrdup(name);
2726
add_object(obj, p, path, name);
2827
}
2928

@@ -78,7 +77,6 @@ static void process_tree(struct rev_info *revs,
7877
if (parse_tree(tree) < 0)
7978
die("bad tree object %s", sha1_to_hex(obj->sha1));
8079
obj->flags |= SEEN;
81-
name = xstrdup(name);
8280
add_object(obj, p, path, name);
8381
me.up = path;
8482
me.elem = name;

reachable.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ static void process_tree(struct tree *tree,
4848
obj->flags |= SEEN;
4949
if (parse_tree(tree) < 0)
5050
die("bad tree object %s", sha1_to_hex(obj->sha1));
51-
name = xstrdup(name);
5251
add_object(obj, p, path, name);
5352
me.up = path;
5453
me.elem = name;

0 commit comments

Comments
 (0)