config.c: fix writing config files on Windows network shares

kblees · gitster · commit 7a64592cf8cc · 2015-06-30T11:01:59.000-07:00
Renaming to an existing file doesn't work on Windows network shares if the
target file is open.

munmap() the old config file before commit_lock_file.

Signed-off-by: Karsten Blees &lt;blees@dcon.de&gt;
Acked-by: Jeff King &lt;peff@peff.net&gt;
Acked-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/config.c b/config.c
@@ -2116,6 +2116,9 @@ int git_config_set_multivar_in_file(const char *config_filename,
 					  contents_sz - copy_begin) <
 			    contents_sz - copy_begin)
 				goto write_err_out;
+
+		munmap(contents, contents_sz);
+		contents = NULL;
 	}
 
 	if (commit_lock_file(lock) < 0) {

Original file line number	Diff line number	Diff line change
`@@ -2116,6 +2116,9 @@ int git_config_set_multivar_in_file(const char *config_filename,`
`2116`	`2116`	`contents_sz - copy_begin) <`
`2117`	`2117`	`contents_sz - copy_begin)`
`2118`	`2118`	`goto write_err_out;`
	`2119`	`+`
	`2120`	`+ munmap(contents, contents_sz);`
	`2121`	`+ contents = NULL;`
`2119`	`2122`	`}`
`2120`	`2123`
`2121`	`2124`	`if (commit_lock_file(lock) < 0) {`