contrib/git-credential-gnome-keyring.c: exit non-zero when called incorrectly

drafnel · gitster · commit 7a6d6423c5a6 · 2013-10-16T09:35:30.000-07:00
If the correct arguments were not specified, this program should exit
non-zero.  Let's do so.

Signed-off-by: Brandon Casey &lt;drafnel@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
@@ -396,7 +396,7 @@ int main(int argc, char *argv[])
 
 	if (!argv[1]) {
 		usage(argv[0]);
-		goto out;
+		exit(EXIT_FAILURE);
 	}
 
 	/* lookup operation callback */

Original file line number	Diff line number	Diff line change
`@@ -396,7 +396,7 @@ int main(int argc, char *argv[])`
`396`	`396`
`397`	`397`	`if (!argv[1]) {`
`398`	`398`	`usage(argv[0]);`
`399`		`- goto out;`
	`399`	`+ exit(EXIT_FAILURE);`
`400`	`400`	`}`
`401`	`401`
`402`	`402`	`/* lookup operation callback */`