Skip to content

Commit 85605ed

Browse files
committed
sequencer: avoid unnecessary indirection
We really do not need the *pointer to a* pointer to the options in the read_populate_opts() function. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 8d4b2d8 commit 85605ed

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

sequencer.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -799,11 +799,11 @@ static int populate_opts_cb(const char *key, const char *value, void *data)
799799
return 0;
800800
}
801801

802-
static int read_populate_opts(struct replay_opts **opts)
802+
static int read_populate_opts(struct replay_opts *opts)
803803
{
804804
if (!file_exists(git_path_opts_file()))
805805
return 0;
806-
if (git_config_from_file(populate_opts_cb, git_path_opts_file(), *opts) < 0)
806+
if (git_config_from_file(populate_opts_cb, git_path_opts_file(), opts) < 0)
807807
return error(_("Malformed options sheet: %s"),
808808
git_path_opts_file());
809809
return 0;
@@ -1018,7 +1018,7 @@ static int sequencer_continue(struct replay_opts *opts)
10181018

10191019
if (!file_exists(git_path_todo_file()))
10201020
return continue_single_pick();
1021-
if (read_populate_opts(&opts) ||
1021+
if (read_populate_opts(opts) ||
10221022
read_populate_todo(&todo_list, opts))
10231023
return -1;
10241024

0 commit comments

Comments
 (0)