Skip to content

Commit 89d5dd4

Browse files
Felipe Contrerasgitster
authored andcommitted
tests: at-combinations: improve nonsense()
In some circumstances 'git log' might fail, but not because the @ parsing failed. For example: 'git rev-parse' might succeed and return a bad object, and then 'git log' would fail. The layer we want to test is revision parsing, so let's test that directly. Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent c8a81e9 commit 89d5dd4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

t/t1508-at-combinations.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ check() {
1818

1919
nonsense() {
2020
test_expect_${2:-success} "$1 is nonsensical" "
21-
test_must_fail git log -1 '$1'
21+
test_must_fail git rev-parse --verify '$1'
2222
"
2323
}
2424

0 commit comments

Comments
 (0)