write_ref_sha1(): only invalidate the loose ref cache

mhagger · gitster · commit 8bf90dc9bdf3 · 2011-10-16T21:12:04.000-07:00
Since write_ref_sha1() can only write loose refs and cannot write
symbolic refs, there is no need for it to invalidate the packed ref
cache.

Suggested by: Martin Fick &lt;mfick@codeaurora.org&gt;
Signed-off-by: Michael Haggerty &lt;mhagger@alum.mit.edu&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/refs.c b/refs.c
@@ -1534,7 +1534,7 @@ int write_ref_sha1(struct ref_lock *lock,
 		unlock_ref(lock);
 		return -1;
 	}
-	invalidate_ref_cache(NULL);
+	clear_loose_ref_cache(get_ref_cache(NULL));
 	if (log_ref_write(lock->ref_name, lock->old_sha1, sha1, logmsg) < 0 ||
 	    (strcmp(lock->ref_name, lock->orig_ref_name) &&
 	     log_ref_write(lock->orig_ref_name, lock->old_sha1, sha1, logmsg) < 0)) {

Original file line number	Diff line number	Diff line change
`@@ -1534,7 +1534,7 @@ int write_ref_sha1(struct ref_lock *lock,`
`1534`	`1534`	`unlock_ref(lock);`
`1535`	`1535`	`return -1;`
`1536`	`1536`	`}`
`1537`		`- invalidate_ref_cache(NULL);`
	`1537`	`+ clear_loose_ref_cache(get_ref_cache(NULL));`
`1538`	`1538`	`if (log_ref_write(lock->ref_name, lock->old_sha1, sha1, logmsg) < 0 \|\|`
`1539`	`1539`	`(strcmp(lock->ref_name, lock->orig_ref_name) &&`
`1540`	`1540`	`log_ref_write(lock->orig_ref_name, lock->old_sha1, sha1, logmsg) < 0)) {`