builtin/log: remove redundant initialization

Michael Schubert · gitster · commit 967cf9867de7 · 2011-12-21T11:15:56.000-08:00
"abbrev" and "commit_format" in struct rev_info get initialized in
init_revisions - no need to reinit in cmd_log_init_defaults.

Signed-off-by: Michael Schubert &lt;mschub@elegosoft.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/log.c b/builtin/log.c
@@ -72,8 +72,6 @@ static int decorate_callback(const struct option *opt, const char *arg, int unse
 
 static void cmd_log_init_defaults(struct rev_info *rev)
 {
-	rev->abbrev = DEFAULT_ABBREV;
-	rev->commit_format = CMIT_FMT_DEFAULT;
 	if (fmt_pretty)
 		get_commit_format(fmt_pretty, rev);
 	rev->verbose_header = 1;

Original file line number	Diff line number	Diff line change
`@@ -72,8 +72,6 @@ static int decorate_callback(const struct option opt, const char arg, int unse`
`72`	`72`
`73`	`73`	`static void cmd_log_init_defaults(struct rev_info *rev)`
`74`	`74`	`{`
`75`		`- rev->abbrev = DEFAULT_ABBREV;`
`76`		`- rev->commit_format = CMIT_FMT_DEFAULT;`
`77`	`75`	`if (fmt_pretty)`
`78`	`76`	`get_commit_format(fmt_pretty, rev);`
`79`	`77`	`rev->verbose_header = 1;`