run-command: dup_devnull(): guard against syscalls failing

Thomas Rast · gitster · commit a77f106c7837 · 2013-07-12T10:30:09.000-07:00
dup_devnull() did not check the return values of open() and dup2().
Fix this omission.

Signed-off-by: Thomas Rast &lt;trast@inf.ethz.ch&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/run-command.c b/run-command.c
@@ -76,7 +76,10 @@ static inline void close_pair(int fd[2])
 static inline void dup_devnull(int to)
 {
 	int fd = open("/dev/null", O_RDWR);
-	dup2(fd, to);
+	if (fd < 0)
+		die_errno(_("open /dev/null failed"));
+	if (dup2(fd, to) < 0)
+		die_errno(_("dup2(%d,%d) failed"), fd, to);
 	close(fd);
 }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,10 @@ static inline void close_pair(int fd[2])`
`76`	`76`	`static inline void dup_devnull(int to)`
`77`	`77`	`{`
`78`	`78`	`int fd = open("/dev/null", O_RDWR);`
`79`		`- dup2(fd, to);`
	`79`	`+ if (fd < 0)`
	`80`	`+ die_errno(_("open /dev/null failed"));`
	`81`	`+ if (dup2(fd, to) < 0)`
	`82`	`+ die_errno(_("dup2(%d,%d) failed"), fd, to);`
`80`	`83`	`close(fd);`
`81`	`84`	`}`
`82`	`85`	`#endif`