t1501: demonstrate NULL pointer access with invalid GIT_WORK_TREE

dscho · gitster · commit aac3eaa6242d · 2017-03-08T14:38:22.000-08:00
When GIT_WORK_TREE does not specify a valid path, we should error
out, instead of crashing.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t1501-work-tree.sh b/t/t1501-work-tree.sh
@@ -423,4 +423,12 @@ test_expect_success '$GIT_WORK_TREE overrides $GIT_DIR/common' '
 	)
 '
 
+test_expect_failure 'error out gracefully on invalid $GIT_WORK_TREE' '
+	(
+		GIT_WORK_TREE=/.invalid/work/tree &&
+		export GIT_WORK_TREE &&
+		test_expect_code 128 git rev-parse
+	)
+'
+
 test_done

Original file line number	Diff line number	Diff line change
`@@ -423,4 +423,12 @@ test_expect_success '$GIT_WORK_TREE overrides $GIT_DIR/common' '`
`423`	`423`	`)`
`424`	`424`	`'`
`425`	`425`
	`426`	`+test_expect_failure 'error out gracefully on invalid $GIT_WORK_TREE' '`
	`427`	`+ (`
	`428`	`+ GIT_WORK_TREE=/.invalid/work/tree &&`
	`429`	`+ export GIT_WORK_TREE &&`
	`430`	`+ test_expect_code 128 git rev-parse`
	`431`	`+ )`
	`432`	`+'`
	`433`	`+`
`426`	`434`	`test_done`