refs: release strbuf on error return in write_pseudoref()

rscharfe · gitster · commit aeb014f6aeca · 2017-09-07T08:49:28.000+09:00
Signed-off-by: Rene Scharfe &lt;l.s.r@web.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/refs.c b/refs.c
@@ -612,7 +612,7 @@ static int write_pseudoref(const char *pseudoref, const unsigned char *sha1,
 	if (fd < 0) {
 		strbuf_addf(err, "could not open '%s' for writing: %s",
 			    filename, strerror(errno));
-		return -1;
+		goto done;
 	}
 
 	if (old_sha1) {

Original file line number	Diff line number	Diff line change
`@@ -612,7 +612,7 @@ static int write_pseudoref(const char pseudoref, const unsigned char sha1,`
`612`	`612`	`if (fd < 0) {`
`613`	`613`	`strbuf_addf(err, "could not open '%s' for writing: %s",`
`614`	`614`	`filename, strerror(errno));`
`615`		`- return -1;`
	`615`	`+ goto done;`
`616`	`616`	`}`
`617`	`617`
`618`	`618`	`if (old_sha1) {`