Skip to content

Commit b54cb79

Browse files
mhaggergitster
authored andcommitted
resolve_ref(): use prefixcmp()
Terminate the link content string one step earlier, allowing prefixcmp() to be used instead of the less clear memcmp(). Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 7bb2bf8 commit b54cb79

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

refs.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -520,8 +520,8 @@ const char *resolve_ref(const char *ref, unsigned char *sha1, int reading, int *
520520
len = readlink(path, buffer, sizeof(buffer)-1);
521521
if (len < 0)
522522
return NULL;
523-
if (len >= 5 && !memcmp("refs/", buffer, 5)) {
524-
buffer[len] = 0;
523+
buffer[len] = 0;
524+
if (!prefixcmp(buffer, "refs/")) {
525525
strcpy(ref_buffer, buffer);
526526
ref = ref_buffer;
527527
if (flag)

0 commit comments

Comments
 (0)