Skip to content

Commit c4b71a7

Browse files
Martin Ågrengitster
authored andcommitted
t5334: document that git push --signed=1 does not work
When accepting booleans as command-line or config options throughout Git, there are several documented synonyms for true and false. However, one particular user is slightly broken: `git push --signed=..` does not understand the integer synonyms for true and false. This is hardly wanted. The --signed option has a different notion of boolean than all other arguments and config options, including the config option corresponding to it, push.gpgSign. Add a test documenting the failure to handle --signed=1. Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent a81383b commit c4b71a7

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

t/t5534-push-signed.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,13 @@ test_expect_success 'push --signed fails with a receiver without push certificat
7171
test_i18ngrep "the receiving end does not support" err
7272
'
7373

74+
test_expect_failure 'push --signed=1 is accepted' '
75+
prepare_dst &&
76+
mkdir -p dst/.git/hooks &&
77+
test_must_fail git push --signed=1 dst noop ff +noff 2>err &&
78+
test_i18ngrep "the receiving end does not support" err
79+
'
80+
7481
test_expect_success GPG 'no certificate for a signed push with no update' '
7582
prepare_dst &&
7683
mkdir -p dst/.git/hooks &&

0 commit comments

Comments
 (0)