cvsserver update: comment about how we shouldn't remove a user-modified file

Matthew Ogilvie · gitster · commit d8574ff209d9 · 2012-10-16T16:16:22.000-07:00
Instead of a comment, we should really add test cases and actually fix it.

Signed-off-by: Matthew Ogilvie &lt;mmogilvi_git@miniinfo.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/git-cvsserver.perl b/git-cvsserver.perl
@@ -1144,6 +1144,10 @@ sub req_update
 
         if ( $meta->{filehash} eq "deleted" )
         {
+            # TODO: If it has been modified in the sandbox, error out
+            #   with the appropriate message, rather than deleting a modified
+            #   file.
+
             my ( $filepart, $dirpart ) = filenamesplit($filename,1);
 
             $log->info("Removing '$filename' from working copy (no longer in the repo)");

Original file line number	Diff line number	Diff line change
`@@ -1144,6 +1144,10 @@ sub req_update`
`1144`	`1144`
`1145`	`1145`	`if ( $meta->{filehash} eq "deleted" )`
`1146`	`1146`	`{`
	`1147`	`+ # TODO: If it has been modified in the sandbox, error out`
	`1148`	`+ # with the appropriate message, rather than deleting a modified`
	`1149`	`+ # file.`
	`1150`	`+`
`1147`	`1151`	`my ( $filepart, $dirpart ) = filenamesplit($filename,1);`
`1148`	`1152`
`1149`	`1153`	`$log->info("Removing '$filename' from working copy (no longer in the repo)");`