Skip to content

Commit db10199

Browse files
rscharfegitster
authored andcommitted
apply: use SWAP macro
Use the exported macro SWAP instead of the file-scoped macro swap and remove the latter's definition. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 568edcb commit db10199

1 file changed

Lines changed: 7 additions & 16 deletions

File tree

apply.c

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2187,29 +2187,20 @@ static int parse_chunk(struct apply_state *state, char *buffer, unsigned long si
21872187
return offset + hdrsize + patchsize;
21882188
}
21892189

2190-
#define swap(a,b) myswap((a),(b),sizeof(a))
2191-
2192-
#define myswap(a, b, size) do { \
2193-
unsigned char mytmp[size]; \
2194-
memcpy(mytmp, &a, size); \
2195-
memcpy(&a, &b, size); \
2196-
memcpy(&b, mytmp, size); \
2197-
} while (0)
2198-
21992190
static void reverse_patches(struct patch *p)
22002191
{
22012192
for (; p; p = p->next) {
22022193
struct fragment *frag = p->fragments;
22032194

2204-
swap(p->new_name, p->old_name);
2205-
swap(p->new_mode, p->old_mode);
2206-
swap(p->is_new, p->is_delete);
2207-
swap(p->lines_added, p->lines_deleted);
2208-
swap(p->old_sha1_prefix, p->new_sha1_prefix);
2195+
SWAP(p->new_name, p->old_name);
2196+
SWAP(p->new_mode, p->old_mode);
2197+
SWAP(p->is_new, p->is_delete);
2198+
SWAP(p->lines_added, p->lines_deleted);
2199+
SWAP(p->old_sha1_prefix, p->new_sha1_prefix);
22092200

22102201
for (; frag; frag = frag->next) {
2211-
swap(frag->newpos, frag->oldpos);
2212-
swap(frag->newlines, frag->oldlines);
2202+
SWAP(frag->newpos, frag->oldpos);
2203+
SWAP(frag->newlines, frag->oldlines);
22132204
}
22142205
}
22152206
}

0 commit comments

Comments
 (0)