pager_in_use: use git_env_bool()

peff · gitster · commit df2a6e38b7e1 · 2017-03-24T12:14:11.000-07:00
The pager_in_use() function predates git_env_bool(), but
ends up doing the same thing.  Let's make use of the latter,
which is shorter and less repetitive.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/pager.c b/pager.c
@@ -166,9 +166,7 @@ void setup_pager(void)
 
 int pager_in_use(void)
 {
-	const char *env;
-	env = getenv("GIT_PAGER_IN_USE");
-	return env ? git_config_bool("GIT_PAGER_IN_USE", env) : 0;
+	return git_env_bool("GIT_PAGER_IN_USE", 0);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -166,9 +166,7 @@ void setup_pager(void)`
`166`	`166`
`167`	`167`	`int pager_in_use(void)`
`168`	`168`	`{`
`169`		`- const char *env;`
`170`		`- env = getenv("GIT_PAGER_IN_USE");`
`171`		`- return env ? git_config_bool("GIT_PAGER_IN_USE", env) : 0;`
	`169`	`+ return git_env_bool("GIT_PAGER_IN_USE", 0);`
`172`	`170`	`}`
`173`	`171`
`174`	`172`	`/*`