gitweb: Use capturing parentheses only when you intend to capture

jnareb · gitster · commit e8bb4b38dfcb · 2009-05-13T10:34:11.000-07:00
Non-capturing groups are useful because they have better runtime
performance and do not copy strings to the magic global capture
variables.

Signed-off-by: Jakub Narebski &lt;jnareb@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
@@ -828,7 +828,7 @@ sub evaluate_path_info {
 if (!defined($actions{$action})) {
 	die_error(400, "Unknown action");
 }
-if ($action !~ m/^(opml|project_list|project_index)$/ &&
+if ($action !~ m/^(?:opml|project_list|project_index)$/ &&
     !$project) {
 	die_error(400, "Project needed");
 }

Original file line number	Diff line number	Diff line change
`@@ -828,7 +828,7 @@ sub evaluate_path_info {`
`828`	`828`	`if (!defined($actions{$action})) {`
`829`	`829`	`die_error(400, "Unknown action");`
`830`	`830`	`}`
`831`		`-if ($action !~ m/^(opml\|project_list\|project_index)$/ &&`
	`831`	`+if ($action !~ m/^(?:opml\|project_list\|project_index)$/ &&`
`832`	`832`	`!$project) {`
`833`	`833`	`die_error(400, "Project needed");`
`834`	`834`	`}`