Skip to content

Commit f6e82b0

Browse files
dschogitster
authored andcommitted
sequencer: lib'ify create_seq_dir()
Instead of dying there, let the caller high up in the callchain notice the error and handle it (by dying, still). The only caller of create_seq_dir(), sequencer_pick_revisions() can already return errors, so its caller must be already prepared to handle error returns, and with this step, we make it notice an error return from this function. So this is a safe conversion to make create_seq_dir() callable from new callers that want it not to die, without changing the external behaviour of anything existing. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 0d00da7 commit f6e82b0

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

sequencer.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -847,8 +847,8 @@ static int create_seq_dir(void)
847847
return -1;
848848
}
849849
else if (mkdir(git_path_seq_dir(), 0777) < 0)
850-
die_errno(_("Could not create sequencer directory %s"),
851-
git_path_seq_dir());
850+
return error_errno(_("Could not create sequencer directory %s"),
851+
git_path_seq_dir());
852852
return 0;
853853
}
854854

0 commit comments

Comments
 (0)