Skip to content

Commit 5846e4f

Browse files
committed
new way of signing
1 parent c1bd9ee commit 5846e4f

1 file changed

Lines changed: 27 additions & 18 deletions

File tree

‎.github/workflows/build.yml‎

Lines changed: 27 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -38,29 +38,38 @@ jobs:
3838

3939
- name: Set up certificate
4040
run: |
41-
echo "${{ secrets.WINDOWS_CERT_DATA }}" | base64 --decode > /d/Certificate_pkcs12.p12
41+
echo "${{ secrets.CODESIGN_WIN_CERT_P12_BASE64 }}" | base64 --decode > /d/Certificate_pkcs12.p12
4242
shell: bash
4343

44-
- name: Set variables
45-
id: variables
46-
run: |
47-
# echo "version=${GITHUB_REF#refs/tags/v}" >> $GITHUB_OUTPUT
48-
echo "SM_HOST=${{ secrets.KEYLOCKER_HOST }}" >> "$GITHUB_ENV"
49-
echo "SM_API_KEY=${{ secrets.KEYLOCKER_API_KEY }}" >> "$GITHUB_ENV"
50-
echo "SM_CLIENT_CERT_FILE=D:\\Certificate_pkcs12.p12" >> "$GITHUB_ENV"
51-
echo "SM_CLIENT_CERT_PASSWORD=${{ secrets.WINDOWS_CERT_PASSWORD }}" >> "$GITHUB_ENV"
52-
shell: bash
44+
- name: Setup Software Trust Manager
45+
uses: digicert/code-signing-software-trust-action@v1
46+
with:
47+
simple-signing-mode: true
48+
# If the below 2 parameters are supplied, then smctl executable is invoked to attempt the signing.
49+
input: binary.exe
50+
keypair-alias: key_1369544803
51+
env:
52+
SM_HOST: ${{ vars.CODESIGN_WIN_KEYLOCKER_HOST }}
53+
SM_API_KEY: ${{ secrets.CODESIGN_WIN_KEYLOCKER_API_KEY }}
54+
SM_CLIENT_CERT_FILE: D:\\Certificate_pkcs12.p12
55+
SM_CLIENT_CERT_PASSWORD: ${{ secrets.CODESIGN_WIN_CERT_P12_PASSWORD }}
56+
shell: bash
5357

54-
# - name: Signing using certificate fingerprint
55-
# run: |
56-
# smctl sign --fingerprint ${{ secrets.KEYLOCKER_CERT_SHA1_HASH }} --input binary.exe --config-file "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\smtools-windows-x64\\pkcs11properties.cfg"
57-
# shell: cmd
5858

59+
# - name: Set variables
60+
# id: variables
61+
# run: |
62+
# echo "version=${GITHUB_REF#refs/tags/v}" >> $GITHUB_OUTPUT
63+
# echo "SM_HOST=${{ secrets.CODESIGN_WIN_KEYLOCKER_HOST }}" >> "$GITHUB_ENV"
64+
# echo "SM_API_KEY=${{ secrets.CODESIGN_WIN_KEYLOCKER_API_KEY }}" >> "$GITHUB_ENV"
65+
# echo "SM_CLIENT_CERT_FILE=D:\\Certificate_pkcs12.p12" >> "$GITHUB_ENV"
66+
# echo "SM_CLIENT_CERT_PASSWORD=${{ secrets.CODESIGN_WIN_CERT_P12_PASSWORD }}" >> "$GITHUB_ENV"
67+
# shell: bash
68+
# - name: Signing using keypair alias
69+
# run: |
70+
# # smctl sign --keypair-alias ${{ secrets.KEYLOCKER_KEYPAIR_ALIAS }} --input binary.exe
5971

60-
- name: Signing using keypair alias
61-
run: |
62-
smctl sign --keypair-alias ${{ secrets.KEYLOCKER_KEYPAIR_ALIAS }} --input binary.exe
63-
shell: cmd
72+
# shell: cmd
6473

6574
- name: upload signed installer
6675
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)