Release update in develop branch

Signed-off-by: Ranjan-Dasgupta <Ranjan.Dasgupta@us.ibm.com>

Author: Ranjan-Dasgupta

.github/ISSUE_TEMPLATE.md

@@ -1,7 +1,7 @@
 Please fill out the form below before submitting, thank you!
 
-- [ ] Bug exists Release Version 1.2.0 ( Master Branch)
-- [ ] Bug exists in MQTTv3 Client on Snapshot Version 1.2.1-SNAPSHOT (Develop Branch)
-- [ ] Bug exists in MQTTv5 Client on Snapshot Version 1.2.1-SNAPSHOT (Develop Branch)
+- [ ] Bug exists Release Version 1.2.3 ( Master Branch)
+- [ ] Bug exists in MQTTv3 Client on Snapshot Version 1.2.4-SNAPSHOT (Develop Branch)
+- [ ] Bug exists in MQTTv5 Client on Snapshot Version 1.2.4-SNAPSHOT (Develop Branch)
 
 If this is a bug regarding the Android Service, please raise the bug here instead: https://github.com/eclipse/paho.mqtt.android/issues/new

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,6 +2,8 @@ Please make sure that the following boxes are checked before submitting your Pul
 
 - [ ] This change is against the develop branch, **not** master.
 - [ ] You have signed the [Eclipse ECA](https://wiki.eclipse.org/ECA)
-- [ ] All of your commits have been signed-off with the correct email address (The same one that you used to sign the CLA) _Hint: use the -s argument when committing_.
-- [ ] If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that you are fixing straight away that you add some Description about the bug and how this will fix it.
+- [ ] All of your commits have been signed-off with the correct email address (the same one that you 
+      used to sign the CLA) _Hint: use the -s argument when committing_.
+- [ ] If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that 
+      you are fixing straight away that you add some Description about the bug and how this will fix it.
 - [ ] If this is new functionality, You have added the appropriate Unit tests.

MQTTv3.md

@@ -11,7 +11,7 @@ Eclipse hosts a Nexus repository for those who want to use Maven to manage their
 Add the repository definition and the dependency definition shown below to your pom.xml.
 
 Replace %REPOURL% with either ``` https://repo.eclipse.org/content/repositories/paho-releases/ ``` for the official releases, or ``` https://repo.eclipse.org/content/repositories/paho-snapshots/  ``` for the nightly snapshots. Replace %VERSION% with the level required .
-The latest release version is ```1.2.1``` and the current snapshot version is ```1.2.2-SNAPSHOT```.
+The latest release version is ```1.2.3``` and the current snapshot version is ```1.2.4-SNAPSHOT```.
 
 ```
 <project ...>

README.md

@@ -32,7 +32,7 @@ Add the repository definition and the dependency definition shown below to your
 
 Replace %REPOURL% with either ``` https://repo.eclipse.org/content/repositories/paho-releases/ ``` for the official releases, or ``` https://repo.eclipse.org/content/repositories/paho-snapshots/  ``` for the nightly snapshots. Replace %VERSION% with the level required .
 
-The latest release version is ```1.2.1``` and the current snapshot version is ```1.2.2-SNAPSHOT```.
+The latest release version is ```1.2.3``` and the current snapshot version is ```1.2.4-SNAPSHOT```.
 
 
 ```

org.eclipse.paho.client.mqttv3.test/src/test/java/org/eclipse/paho/client/mqttv3/test/SendReceiveAsyncTest.java

@@ -676,7 +676,10 @@ public void testConnectTimeout() throws Exception {
 	  catch (Exception exception) {
 		  log.log(Level.INFO, "Connect action failed as expected.");
 		  Assert.assertTrue(exception instanceof MqttException);
-		  Assert.assertEquals(MqttException.REASON_CODE_CLIENT_TIMEOUT, ((MqttException) exception).getReasonCode());
+		  Assert.assertEquals((
+                      MqttException.REASON_CODE_CLIENT_TIMEOUT == ((MqttException) exception).getReasonCode() || 
+                      MqttException.REASON_CODE_CLIENT_EXCEPTION == ((MqttException) exception).getReasonCode()),
+                      true);
 	  }
 	  finally {
 		  if (mqttClient != null) {
@@ -694,10 +697,11 @@ public void testConnectTimeout() throws Exception {
 	  catch (Exception exception) {
 		  log.log(Level.INFO, "Connect action failed as expected.");
 		  Assert.assertTrue(exception instanceof MqttException);
-		  Assert.assertEquals(
-				  (MqttException.REASON_CODE_CLIENT_TIMEOUT == ((MqttException) exception).getReasonCode() ||
-				   MqttException.REASON_CODE_CONNECT_IN_PROGRESS == ((MqttException) exception).getReasonCode())
-				  , true);
+		  Assert.assertEquals((
+                      MqttException.REASON_CODE_CLIENT_TIMEOUT == ((MqttException) exception).getReasonCode() || 
+                      MqttException.REASON_CODE_CLIENT_EXCEPTION == ((MqttException) exception).getReasonCode() ||
+		      MqttException.REASON_CODE_CONNECT_IN_PROGRESS == ((MqttException) exception).getReasonCode()),
+		      true);
 	  }
 	  finally {
 		  if (mqttClient != null) {

pom.xml

@@ -4,7 +4,7 @@
 	<groupId>org.eclipse.paho</groupId>
 	<artifactId>java-parent</artifactId>
 	<packaging>pom</packaging>
-	<version>1.2.2-SNAPSHOT</version>
+	<version>1.2.4-SNAPSHOT</version>
 
 	<properties>
 		<!-- source & target java version for MQTT Client -->