Skip to content

Commit 3906943

Browse files
committed
Fixing Logging in DisconnectedMessageBuffer where the incorrect message was being shown.
Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
1 parent c2af15d commit 3906943

4 files changed

Lines changed: 8 additions & 6 deletions

File tree

org.eclipse.paho.client.mqttv3/src/main/java/org/eclipse/paho/client/mqttv3/internal/DisconnectedMessageBuffer.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ public class DisconnectedMessageBuffer implements Runnable {
3030
private static final String CLASS_NAME = "DisconnectedMessageBuffer";
3131
private Logger log = LoggerFactory.getLogger(LoggerFactory.MQTT_CLIENT_MSG_CAT, CLASS_NAME);
3232
private DisconnectedBufferOptions bufferOpts;
33-
private ArrayList buffer;
33+
private ArrayList<BufferedMessage> buffer;
3434
private Object bufLock = new Object(); // Used to synchronise the buffer
3535
private IDisconnectedBufferCallback callback;
3636

3737
public DisconnectedMessageBuffer(DisconnectedBufferOptions options){
3838
this.bufferOpts = options;
39-
buffer = new ArrayList();
39+
buffer = new ArrayList<BufferedMessage>();
4040
}
4141

4242
/**
@@ -110,8 +110,8 @@ public void run() {
110110
deleteMessage(0);
111111
} catch (MqttException ex) {
112112
// Error occurred attempting to publish buffered message likely because the client is not connected
113-
// @TRACE 517=Error occurred attempting to publish buffered message due to disconnect.
114-
log.warning(CLASS_NAME, methodName, "517");
113+
// @TRACE 519=Error occurred attempting to publish buffered message due to disconnect. Exception: {0}.
114+
log.warning(CLASS_NAME, methodName, "519", new Object[]{ex.getMessage()});
115115
break;
116116
}
117117
}

org.eclipse.paho.client.mqttv3/src/main/resources/org/eclipse/paho/client/mqttv3/internal/nls/logcat.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@
8080
516=Restoring all buffered messages.
8181
517=Un-Persisting Buffered message key={0}
8282
518=Failed to Un-Persist Buffered message key={0}
83+
519=Error occurred attempting to publish buffered message due to disconnect. Exception: {0}.
8384
529=Sent {0}
8485
600=>
8586
601=key={0} message={1}

org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/internal/DisconnectedMessageBuffer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ public void run() {
111111
deleteMessage(0);
112112
} catch (MqttException ex) {
113113
// Error occurred attempting to publish buffered message likely because the client is not connected
114-
// @TRACE 517=Error occurred attempting to publish buffered message due to disconnect.
115-
log.warning(CLASS_NAME, methodName, "517");
114+
// @TRACE 519=Error occurred attempting to publish buffered message due to disconnect. Exception: {0}.
115+
log.warning(CLASS_NAME, methodName, "519", new Object[]{ex.getMessage()});
116116
break;
117117
}
118118
}

org.eclipse.paho.mqttv5.client/src/main/resources/org/eclipse/paho/mqttv5/client/internal/nls/logcat.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@
8080
516=Restoring all buffered messages.
8181
517=Un-Persisting Buffered message key={0}
8282
518=Failed to Un-Persist Buffered message key={0}
83+
519=Error occurred attempting to publish buffered message due to disconnect. Exception: {0}.
8384
529=Sent {0}
8485
530=Received {0}
8586
600=>

0 commit comments

Comments
 (0)