Skip to content

Commit 44cbbb5

Browse files
Ian CraggsGerrit Code Review @ Eclipse.org
authored andcommitted
Merge "Fixing Subscription list item and Message list item layouts for Android Jelly bean" into develop
2 parents 73c4583 + da2085f commit 44cbbb5

4 files changed

Lines changed: 14 additions & 18 deletions

File tree

org.eclipse.paho.android.service/org.eclipse.paho.android.sample/src/main/AndroidManifest.xml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
3-
package="org.eclipse.paho.android.sample" >
3+
xmlns:tools="http://schemas.android.com/tools"
4+
package="org.eclipse.paho.android.sample">
45

56

67
<!-- Permissions the Application Requires -->
@@ -17,7 +18,8 @@
1718
android:allowBackup="true"
1819
android:icon="@mipmap/ic_launcher"
1920
android:label="@string/app_name"
20-
android:theme="@style/MaterialTheme" >
21+
android:theme="@style/MaterialTheme"
22+
tools:replace="android:theme">
2123

2224
<!-- Mqtt Service -->
2325
<service android:name="org.eclipse.paho.android.service.MqttService" >
@@ -34,13 +36,6 @@
3436
</intent-filter>
3537

3638
</activity>
37-
<activity
38-
android:name=".activity.EditConnectionActivity"
39-
android:label="@string/action_add_connection" >
40-
<meta-data
41-
android:name="android.support.PARENT_ACTIVITY"
42-
android:value="org.eclipse.paho.android.sample.activity.MainActivity"/>
43-
</activity>
4439
</application>
4540

4641
</manifest>

org.eclipse.paho.android.service/org.eclipse.paho.android.sample/src/main/java/org/eclipse/paho/android/sample/components/MessageListItemAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public View getView(final int position, View convertView, ViewGroup parent){
4141
topicTextView.setText(new String("Topic: " + messages.get(position).getTopic()));
4242
SimpleDateFormat format = new SimpleDateFormat("HH:mm:ss");
4343
String shortDateStamp = format.format(messages.get(position).getTimestamp());
44-
dateTextView.setText("Date: " + shortDateStamp);
44+
dateTextView.setText("Time: " + shortDateStamp);
4545
return rowView;
4646
}
4747
}

org.eclipse.paho.android.service/org.eclipse.paho.android.sample/src/main/res/layout/message_list_item.xml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
android:id="@+id/message_topic_text"
88
android:layout_width="fill_parent"
99
android:layout_height="26dip"
10-
android:layout_alignParentBottom="true"
11-
android:layout_alignParentRight="true"
1210
android:ellipsize="marquee"
1311
android:singleLine="true"
1412
android:text="Topic: "
1513
android:textSize="12sp"
16-
android:layout_toEndOf="@+id/message_date_text" />
14+
android:layout_below="@+id/message_text"
15+
android:layout_alignParentLeft="true"
16+
android:layout_alignParentStart="true" />
1717

1818
<TextView
1919
android:id="@+id/message_text"
@@ -31,9 +31,10 @@
3131
android:layout_height="26dip"
3232
android:text="Time:"
3333
android:id="@+id/message_date_text"
34-
android:layout_alignTop="@+id/message_topic_text"
35-
android:layout_alignParentStart="true"
36-
android:textSize="12dip" />
34+
android:textSize="12dip"
35+
android:layout_below="@+id/message_text"
36+
android:layout_alignParentRight="true"
37+
android:layout_alignParentEnd="true" />
3738

3839

3940
</RelativeLayout>

org.eclipse.paho.android.service/org.eclipse.paho.android.sample/src/main/res/layout/subscription_list_item.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
android:layout_marginRight="6dip"
4646
android:contentDescription="TODO"
4747
android:src="@drawable/ic_delete"
48-
android:layout_alignTop="@+id/icon"
49-
android:layout_alignEnd="@+id/message_text" />
48+
android:layout_alignEnd="@+id/message_text"
49+
android:layout_alignParentRight="true" />
5050

5151
</RelativeLayout>

0 commit comments

Comments
 (0)