Skip to content

Commit 6e8f2bf

Browse files
authored
Merge pull request #588 from chongyuanyin/develop
Fix issues on Maximum QoS and Receive Maximum properties for MQTT 5.0
2 parents 5aedf07 + fee4af0 commit 6e8f2bf

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/internal/MqttConnectionState.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@ public void clearConnectionState() {
5353

5454

5555
public Integer getReceiveMaximum() {
56+
if (receiveMaximum == null) {
57+
return 65535;
58+
}
5659
return receiveMaximum;
5760
}
5861

org.eclipse.paho.mqttv5.common/src/main/java/org/eclipse/paho/mqttv5/common/packet/MqttProperties.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ public byte[] encodeProperties() throws MqttException {
336336
// Maximum QoS
337337
if (maximumQoS != null && validProperties.contains(MAXIMUM_QOS_IDENTIFIER)) {
338338
outputStream.write(MAXIMUM_QOS_IDENTIFIER);
339-
outputStream.writeShort(maximumQoS);
339+
outputStream.writeByte(maximumQoS);
340340
}
341341

342342
// Retain Available
@@ -476,7 +476,7 @@ public void decodeProperties(DataInputStream dis) throws IOException, MqttExcept
476476
} else if (identifier == TOPIC_ALIAS_IDENTIFIER) {
477477
topicAlias = (int) inputStream.readShort();
478478
} else if (identifier == MAXIMUM_QOS_IDENTIFIER) {
479-
maximumQoS = (int) inputStream.readShort();
479+
maximumQoS = inputStream.read();
480480
} else if (identifier == RETAIN_AVAILABLE_IDENTIFIER) {
481481
retainAvailable = inputStream.readBoolean();
482482
} else if (identifier == USER_DEFINED_PAIR_IDENTIFIER) {

0 commit comments

Comments
 (0)