Tweaking some datatype tests and adding -q flag to travis build to hide download messages

Signed-off-by: James Sutton <james.sutton@uk.ibm.com>

Author: jpwsutton

.travis.yml

@@ -14,13 +14,13 @@ before_install:
   - ./start-broker.sh
 
 script:
-  - mvn -B clean
-  - mvn -B --projects org.eclipse.paho.client.mqttv3,org.eclipse.paho.client.mqttv3.test test
-  - mvn -B --projects org.eclipse.paho.mqttv5.common,org.eclipse.paho.mqttv5.client test
+  - mvn -B clean -q
+  - mvn -B --projects org.eclipse.paho.client.mqttv3,org.eclipse.paho.client.mqttv3.test test -q
+  - mvn -B --projects org.eclipse.paho.mqttv5.common,org.eclipse.paho.mqttv5.client test -q
 
-addons:
-  apt:
-    sources:
-      - sourceline: 'ppa:mosquitto-dev/mosquitto-ppa'
-    packages:
-      - mosquitto
+#addons:
+#  apt:
+#    sources:
+#      - sourceline: 'ppa:mosquitto-dev/mosquitto-ppa'
+#    packages:
+#      - mosquitto

org.eclipse.paho.mqttv5.common/src/main/java/org/eclipse/paho/mqttv5/common/packet/MqttDataTypes.java

@@ -171,7 +171,7 @@ private static void validateUTF8String(String input) throws IllegalArgumentExcep
 		for (int i = 0; i < input.length(); i++) {
 			char c = input.charAt(i);
 			if (Character.getType(c) == Character.CONTROL || Character.getType(c) == Character.UNASSIGNED) {
-				throw new IllegalArgumentException("Invalid UTF-8 character : " + c);
+				throw new IllegalArgumentException(String.format("Invalid UTF-8 char: %s [%s]", c, (int) c));
 			}
 		}
 	}

org.eclipse.paho.mqttv5.common/src/test/java/org/eclipse/paho/mqttv5/common/MqttDataTypesTest.java

@@ -8,7 +8,6 @@
 import java.io.File;
 import java.io.FileReader;
 import java.io.IOException;
-
 import org.eclipse.paho.mqttv5.common.packet.MqttDataTypes;
 import org.junit.Assert;
 import org.junit.Test;
@@ -115,8 +114,9 @@ public void TestEncodeAndDecodeComplexUTF8String() throws MqttException {
 	}
 
 	/**
-	 * Tests that a large number of complex UTF-8 strings can be encoded and decoded successfully.
-	 * Uses "i_can_eat_glass.txt" as a source of strings that are in the Language:testString format
+	 * Tests that a large number of complex UTF-8 strings can be encoded and decoded
+	 * successfully. Uses "i_can_eat_glass.txt" as a source of strings that are in
+	 * the Language:testString format
 	 * 
 	 * @throws IOException
 	 * @throws MqttException
@@ -137,7 +137,5 @@ public void testICanEatGlass() throws IOException, MqttException {
 
 			}
 		}
-
 	}
-
 }

start-broker.sh

@@ -32,7 +32,7 @@ if [ "$BROKER" == "MOSQUITTO" ]; then
 	fi
 else 
 	echo "Installing and starting Python Interop Broker."
-	sudo service mosquitto stop
+	#sudo service mosquitto stop
 	git clone https://github.com/eclipse/paho.mqtt.testing.git
 	cp java_client_testing.conf paho.mqtt.testing/interoperability/.
 	cd paho.mqtt.testing/interoperability