Skip to content

Commit d083428

Browse files
committed
Cleaning up unused files in V3 and V5 clients
Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
1 parent d8b0547 commit d083428

15 files changed

Lines changed: 11 additions & 301 deletions

File tree

org.eclipse.paho.client.mqttv3/src/main/java/org/eclipse/paho/client/mqttv3/internal/ClientDefaults.java

Lines changed: 0 additions & 20 deletions
This file was deleted.

org.eclipse.paho.client.mqttv3/src/main/java/org/eclipse/paho/client/mqttv3/internal/TCPNetworkModule.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import java.io.InputStream;
2020
import java.io.OutputStream;
2121
import java.net.ConnectException;
22-
import java.net.InetAddress;
2322
import java.net.InetSocketAddress;
2423
import java.net.Socket;
2524
import java.net.SocketAddress;

org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/internal/ClientComms.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,6 @@ public class ClientComms {
8888
private ExecutorService executorService;
8989
private MqttSession mqttSession;
9090

91-
92-
93-
9491
/**
9592
* Creates a new ClientComms object, using the specified module to handle the
9693
* network calls.
@@ -104,7 +101,7 @@ public class ClientComms {
104101
* @param executorService
105102
* the {@link ExecutorService}
106103
* @param mqttSession
107-
* the {@link MqttSession}
104+
* the {@link MqttSession}
108105
* @throws MqttException
109106
* if an exception occurs whilst communicating with the server
110107
*/
@@ -208,16 +205,16 @@ public void sendNoWait(MqttWireMessage message, MqttToken token) throws MqttExce
208205

209206
if (message instanceof MqttPublish) {
210207
// Override the QoS if the server has set a maximum
211-
if (this.mqttSession.getMaximumQoS()!= null &&
212-
((MqttPublish) message).getMessage().getQos() > this.mqttSession.getMaximumQoS()) {
208+
if (this.mqttSession.getMaximumQoS() != null
209+
&& ((MqttPublish) message).getMessage().getQos() > this.mqttSession.getMaximumQoS()) {
213210
MqttMessage mqttMessage = ((MqttPublish) message).getMessage();
214211
mqttMessage.setQos(this.mqttSession.getMaximumQoS());
215212
((MqttPublish) message).setMessage(mqttMessage);
216213
}
217214

218215
// Override the Retain flag if the server has disabled it
219-
if (this.mqttSession.isRetainAvailable()!= null &&
220-
((MqttPublish) message).getMessage().isRetained()
216+
if (this.mqttSession.isRetainAvailable() != null
217+
&& ((MqttPublish) message).getMessage().isRetained()
221218
&& (this.mqttSession.isRetainAvailable() == false)) {
222219
MqttMessage mqttMessage = ((MqttPublish) message).getMessage();
223220
mqttMessage.setRetained(false);
@@ -316,11 +313,8 @@ public void connect(MqttConnectionOptions options, MqttToken token) throws MqttE
316313
conOptions.isCleanSession(), conOptions.getKeepAliveInterval(),
317314
conOptions.getConnectionProperties(), conOptions.getWillMessageProperties());
318315

319-
System.err.println(connect.toString());
320-
321316
if (conOptions.getWillDestination() != null) {
322317
connect.setWillDestination(conOptions.getWillDestination());
323-
324318
}
325319

326320
if (conOptions.getWillMessage() != null) {
@@ -602,7 +596,7 @@ public void disconnectForcibly(long quiesceTimeout, long disconnectTimeout, int
602596
* @param reasonCode
603597
* the disconnection reason code.
604598
* @param disconnectProperties
605-
* the {@link MqttProperties} to send in the Disconnect packet.
599+
* the {@link MqttProperties} to send in the Disconnect packet.
606600
* @throws MqttException
607601
* if an error occurs whilst disconnecting
608602
*/

org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/internal/ClientDefaults.java

Lines changed: 0 additions & 20 deletions
This file was deleted.

org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/internal/CommsReceiver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import org.eclipse.paho.mqttv5.client.MqttToken;
2626
import org.eclipse.paho.mqttv5.client.logging.Logger;
2727
import org.eclipse.paho.mqttv5.client.logging.LoggerFactory;
28-
import org.eclipse.paho.mqttv5.client.oldwire.MqttInputStream;
28+
import org.eclipse.paho.mqttv5.client.wire.MqttInputStream;
2929
import org.eclipse.paho.mqttv5.common.MqttException;
3030
import org.eclipse.paho.mqttv5.common.packet.MqttAck;
3131
import org.eclipse.paho.mqttv5.common.packet.MqttDisconnect;

org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/internal/CommsSender.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import org.eclipse.paho.mqttv5.client.MqttToken;
2727
import org.eclipse.paho.mqttv5.client.logging.Logger;
2828
import org.eclipse.paho.mqttv5.client.logging.LoggerFactory;
29-
import org.eclipse.paho.mqttv5.client.oldwire.MqttOutputStream;
29+
import org.eclipse.paho.mqttv5.client.wire.MqttOutputStream;
3030
import org.eclipse.paho.mqttv5.common.MqttException;
3131
import org.eclipse.paho.mqttv5.common.packet.MqttAck;
3232
import org.eclipse.paho.mqttv5.common.packet.MqttDisconnect;

org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/internal/ConnectActionListener.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ public void onSuccess(IMqttToken token) {
114114

115115
// Set properties imposed on us by the Server
116116
MqttToken myToken = (MqttToken) token;
117-
System.out.println(myToken.getMessageProperties().toString());
118117
mqttSession.setReceiveMaximum(myToken.getMessageProperties().getReceiveMaximum());
119118
mqttSession.setMaximumQoS(myToken.getMessageProperties().getMaximumQoS());
120119
mqttSession.setRetainAvailable(myToken.getMessageProperties().isRetainAvailable());

org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/oldwire/CountingInputStream.java

Lines changed: 0 additions & 59 deletions
This file was deleted.

org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/oldwire/MqttAck.java

Lines changed: 0 additions & 38 deletions
This file was deleted.

org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/oldwire/MqttReceivedMessage.java

Lines changed: 0 additions & 35 deletions
This file was deleted.

0 commit comments

Comments
 (0)