There is no socket read timeout set currently and default is to set to zero i.e. wait forever. Adding socket read timeout will help recovering from edge cases where packets are lost on the wire and MqttInputStream.readMqttWireMessage() fails to notify ClientState. In fact, readMqttWireMessage does handle the case for exception thrown due to socket read timeout and ignore it.

Signed-off-by: Rehan Shaukat <rehan.shaukat@gmail.com>

Author: rehanshaukat

org.eclipse.paho.client.mqttv3/src/main/java/org/eclipse/paho/client/mqttv3/internal/TCPNetworkModule.java

@@ -80,6 +80,7 @@ public void start() throws IOException, MqttException {
 				socket = factory.createSocket();
 				socket.connect(sockaddr, conTimeout*1000);
 			}
+			socket.setSoTimeout(1000);
 		}
 		catch (ConnectException ex) {
 			//@TRACE 250=Failed to create TCP socket

org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/internal/TCPNetworkModule.java

@@ -83,7 +83,8 @@ public void start() throws IOException, MqttException {
 				socket = factory.createSocket();
 				socket.connect(sockaddr, conTimeout*1000);
 			}
-		
+			socket.setSoTimeout(1000);
+
 			// SetTcpNoDelay was originally set ot true disabling Nagle's algorithm.
 			// This should not be required.
 //			socket.setTcpNoDelay(true);	// TCP_NODELAY on, which means we do not use Nagle's algorithm