Revert "Reduced php version from 5.6 to 5.3.9"

This reverts commit 046b96f.

Author: Manuele Vaccari

.travis.yml

@@ -10,17 +10,6 @@ cache:
 matrix:
   fast_finish: true
   include:
-    - php: 5.3
-      env: SYMFONY_VERSION=^2.8
-
-    - php: 5.4
-      env: SYMFONY_VERSION=^2.8
-
-    - php: 5.5
-      env: SYMFONY_VERSION=^2.8
-    - php: 5.5
-      env: SYMFONY_VERSION=^3
-
     - php: 5.6
       env: SYMFONY_VERSION=^2.8
     - php: 5.6

composer.json

@@ -1,7 +1,9 @@
 {
   "name": "excelwebzone/recaptcha-bundle",
   "description": "This bundle provides easy reCAPTCHA form field integration",
-  "keywords": ["recaptcha"],
+  "keywords": [
+    "recaptcha"
+  ],
   "homepage": "https://github.com/excelwebzone/EWZRecaptchaBundle",
   "type": "symfony-bundle",
   "license": "MIT",
@@ -13,15 +15,15 @@
     }
   ],
   "require": {
-    "php": ">=5.3.9 || ^7.0",
+    "php": ">=5.6 || ^7.0",
     "google/recaptcha": "^1.1",
     "symfony/form": "^2.8 || ^3.0 || ^4.0",
     "symfony/framework-bundle": "^2.8 || ^3.0 || ^4.0",
     "symfony/security-bundle": "^2.8 || ^3.0 || ^4.0",
     "symfony/validator": "^2.8 || ^3.0 || ^4.0"
   },
   "require-dev": {
-    "phpunit/phpunit": "^4 || ^5 || ^6 || ^7"
+    "phpunit/phpunit": "^5 || ^6 || ^7"
   },
   "autoload": {
     "psr-4": {

src/DependencyInjection/EWZRecaptchaExtension.php

@@ -63,7 +63,7 @@ protected function registerWidget(ContainerBuilder $container)
     private function getTwigFormResources(ContainerBuilder $container)
     {
         if (!$container->hasParameter('twig.form.resources'))
-            return array();
+            return [];
 
         return $container->getParameter('twig.form.resources');
     }

src/Form/Type/EWZRecaptchaType.php

@@ -3,6 +3,7 @@
 namespace EWZ\Bundle\RecaptchaBundle\Form\Type;
 
 use EWZ\Bundle\RecaptchaBundle\Locale\LocaleResolver;
+use Symfony\Component\Form\Extension\Core\Type\TextType;
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\Form\FormView;
 use Symfony\Component\Form\AbstractType;
@@ -15,14 +16,14 @@ class EWZRecaptchaType extends AbstractType
 {
     /**
      * The reCAPTCHA server URL.
-     *
+     * 
      * @var string
      */
     protected $recaptchaApiServer;
-
+    
     /**
      * The reCAPTCHA JS server URL.
-     *
+     * 
      * @var string
      */
     protected $recaptchaApiJsServer;
@@ -141,7 +142,7 @@ public function configureOptions(OptionsResolver $resolver)
      */
     public function getParent()
     {
-        return 'Symfony\Component\Form\Extension\Core\Type\TextType';
+        return TextType::class;
     }
 
     /**

tests/Form/Type/EWZRecaptchaTypeTest.php

@@ -5,7 +5,10 @@
 use EWZ\Bundle\RecaptchaBundle\Form\Type\EWZRecaptchaType;
 use EWZ\Bundle\RecaptchaBundle\Locale\LocaleResolver;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Form\Extension\Core\Type\TextType;
+use Symfony\Component\Form\FormInterface;
 use Symfony\Component\Form\FormView;
+use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class EWZRecaptchaTypeTest extends TestCase
@@ -15,7 +18,7 @@ class EWZRecaptchaTypeTest extends TestCase
 
     protected function setUp()
     {
-        $requestStack = $this->createMock('Symfony\Component\HttpFoundation\RequestStack');
+        $requestStack = $this->createMock(RequestStack::class);
         $localeResolver = new LocaleResolver('de', false, $requestStack);
         $this->type = new EWZRecaptchaType('key', true, true, $localeResolver, 'www.google.com');
     }
@@ -27,7 +30,8 @@ public function buildView()
     {
         $view = new FormView();
 
-        $form = $this->createMock('Symfony\Component\Form\FormInterface');
+        /** @var FormInterface $form */
+        $form = $this->createMock(FormInterface::class);
 
         $this->assertArrayNotHasKey('ewz_recaptcha_enabled', $view->vars);
         $this->assertArrayNotHasKey('ewz_recaptcha_ajax', $view->vars);
@@ -43,7 +47,7 @@ public function buildView()
      */
     public function getParent()
     {
-        $this->assertSame('Symfony\Component\Form\Extension\Core\Type\TextType', $this->type->getParent());
+        $this->assertSame(TextType::class, $this->type->getParent());
     }
 
     /**

tests/Locale/LocaleResolverTest.php

@@ -4,6 +4,8 @@
 
 use EWZ\Bundle\RecaptchaBundle\Locale\LocaleResolver;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\RequestStack;
 
 class LocaleResolverTest extends TestCase
 {
@@ -12,10 +14,10 @@ class LocaleResolverTest extends TestCase
      */
     public function resolveWithLocaleFromRequest()
     {
-        $request = $this->createMock('Symfony\Component\HttpFoundation\Request');
+        $request = $this->createMock(Request::class);
         $request->expects($this->once())->method('getLocale');
 
-        $requestStack = $this->createMock('Symfony\Component\HttpFoundation\RequestStack');
+        $requestStack = $this->createMock(RequestStack::class);
         $requestStack
             ->expects($this->once())
             ->method('getCurrentRequest')
@@ -30,7 +32,7 @@ public function resolveWithLocaleFromRequest()
      */
     public function resolveWithDefaultLocale()
     {
-        $requestStack = $this->createMock('Symfony\Component\HttpFoundation\RequestStack');
+        $requestStack = $this->createMock(RequestStack::class);
         $requestStack
             ->expects($this->never())
             ->method('getCurrentRequest');