Delete deprecated CatalystInstanceImpl and C++ counterparts (#55789)

Summary:
Pull Request resolved: #55789

Removes the deprecated `CatalystInstanceImpl` class (Java) and its C++ JNI
counterparts (`CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp`) as part
of the Legacy Architecture cleanup.

`CatalystInstanceImpl` was the bridge implementation for the old architecture.
Its sole consumer, `ReactInstanceManager`, is itself deprecated — its
constructor already throws `UnsupportedOperationException`. The
`createReactContext` method that instantiated `CatalystInstanceImpl` has been
stubbed to throw `UnsupportedOperationException` as well.

Changes:
- Deleted `CatalystInstanceImpl.java` (621 lines)
- Deleted `CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp` (523 lines)
- Stubbed `ReactInstanceManager.createReactContext` to throw
- Removed from BUCK and CMakeLists.txt build files
- Removed from ReactAndroid.api public API surface
- Removed from ReactNoNewJavaDetector Java allowlist
- Removed from legacy architecture tracking script
- Added direct `#include <cxxreact/MessageQueueThread.h>` to
  `JavaModuleWrapper.cpp` to replace transitive dependency

Changelog: [Android][Removed] - Remove deprecated CatalystInstanceImpl

Reviewed By: javache

Differential Revision: D94548637

fbshipit-source-id: 5c447b85c80605cff17c1555d62ede5e9e2f18a7

Author: mdvacca

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -600,59 +600,6 @@ public abstract interface class com/facebook/react/bridge/CatalystInstance : com
 	public abstract fun setTurboModuleRegistry (Lcom/facebook/react/internal/turbomodule/core/interfaces/TurboModuleRegistry;)V
 }
 
-public class com/facebook/react/bridge/CatalystInstanceImpl : com/facebook/react/bridge/CatalystInstance {
-	public fun callFunction (Lcom/facebook/react/bridge/CatalystInstanceImpl$PendingJSCall;)V
-	public fun callFunction (Ljava/lang/String;Ljava/lang/String;Lcom/facebook/react/bridge/NativeArray;)V
-	public fun destroy ()V
-	public fun extendNativeModules (Lcom/facebook/react/bridge/NativeModuleRegistry;)V
-	public fun getFabricUIManager ()Lcom/facebook/react/bridge/UIManager;
-	public fun getJSCallInvokerHolder ()Lcom/facebook/react/turbomodule/core/CallInvokerHolderImpl;
-	public synthetic fun getJSCallInvokerHolder ()Lcom/facebook/react/turbomodule/core/interfaces/CallInvokerHolder;
-	public fun getJSModule (Ljava/lang/Class;)Lcom/facebook/react/bridge/JavaScriptModule;
-	public fun getJavaScriptContextHolder ()Lcom/facebook/react/bridge/JavaScriptContextHolder;
-	public fun getNativeMethodCallInvokerHolder ()Lcom/facebook/react/turbomodule/core/NativeMethodCallInvokerHolderImpl;
-	public synthetic fun getNativeMethodCallInvokerHolder ()Lcom/facebook/react/turbomodule/core/interfaces/NativeMethodCallInvokerHolder;
-	public fun getNativeModule (Ljava/lang/Class;)Lcom/facebook/react/bridge/NativeModule;
-	public fun getNativeModule (Ljava/lang/String;)Lcom/facebook/react/bridge/NativeModule;
-	public fun getNativeModules ()Ljava/util/Collection;
-	public fun getReactQueueConfiguration ()Lcom/facebook/react/bridge/queue/ReactQueueConfiguration;
-	public fun getRuntimeExecutor ()Lcom/facebook/react/bridge/RuntimeExecutor;
-	public fun getRuntimeScheduler ()Lcom/facebook/react/bridge/RuntimeScheduler;
-	public fun getSourceURL ()Ljava/lang/String;
-	public fun handleMemoryPressure (I)V
-	public fun hasNativeModule (Ljava/lang/Class;)Z
-	public fun hasRunJSBundle ()Z
-	public fun invokeCallback (ILcom/facebook/react/bridge/NativeArrayInterface;)V
-	public fun isDestroyed ()Z
-	public fun loadScriptFromAssets (Landroid/content/res/AssetManager;Ljava/lang/String;Z)V
-	public fun loadScriptFromFile (Ljava/lang/String;Ljava/lang/String;Z)V
-	public fun loadSplitBundleFromFile (Ljava/lang/String;Ljava/lang/String;)V
-	public fun registerSegment (ILjava/lang/String;)V
-	public fun runJSBundle ()V
-	public fun setFabricUIManager (Lcom/facebook/react/bridge/UIManager;)V
-	public fun setGlobalVariable (Ljava/lang/String;Ljava/lang/String;)V
-	public fun setSourceURLs (Ljava/lang/String;Ljava/lang/String;)V
-	public fun setTurboModuleRegistry (Lcom/facebook/react/internal/turbomodule/core/interfaces/TurboModuleRegistry;)V
-}
-
-public class com/facebook/react/bridge/CatalystInstanceImpl$Builder {
-	public fun <init> ()V
-	public fun build ()Lcom/facebook/react/bridge/CatalystInstanceImpl;
-	public fun setJSBundleLoader (Lcom/facebook/react/bridge/JSBundleLoader;)Lcom/facebook/react/bridge/CatalystInstanceImpl$Builder;
-	public fun setJSExceptionHandler (Lcom/facebook/react/bridge/JSExceptionHandler;)Lcom/facebook/react/bridge/CatalystInstanceImpl$Builder;
-	public fun setJSExecutor (Lcom/facebook/react/bridge/JavaScriptExecutor;)Lcom/facebook/react/bridge/CatalystInstanceImpl$Builder;
-	public fun setReactQueueConfigurationSpec (Lcom/facebook/react/bridge/queue/ReactQueueConfigurationSpec;)Lcom/facebook/react/bridge/CatalystInstanceImpl$Builder;
-	public fun setRegistry (Lcom/facebook/react/bridge/NativeModuleRegistry;)Lcom/facebook/react/bridge/CatalystInstanceImpl$Builder;
-}
-
-public class com/facebook/react/bridge/CatalystInstanceImpl$PendingJSCall {
-	public field mArguments Lcom/facebook/react/bridge/NativeArray;
-	public field mMethod Ljava/lang/String;
-	public field mModule Ljava/lang/String;
-	public fun <init> (Ljava/lang/String;Ljava/lang/String;Lcom/facebook/react/bridge/NativeArray;)V
-	public fun toString ()Ljava/lang/String;
-}
-
 public final class com/facebook/react/bridge/ColorPropConverter {
 	public static final field INSTANCE Lcom/facebook/react/bridge/ColorPropConverter;
 	public static final fun getColor (Ljava/lang/Object;Landroid/content/Context;)Ljava/lang/Integer;

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

@@ -13,9 +13,6 @@
 import static com.facebook.react.bridge.ReactMarkerConstants.BUILD_NATIVE_MODULE_REGISTRY_END;
 import static com.facebook.react.bridge.ReactMarkerConstants.BUILD_NATIVE_MODULE_REGISTRY_START;
 import static com.facebook.react.bridge.ReactMarkerConstants.CHANGE_THREAD_PRIORITY;
-import static com.facebook.react.bridge.ReactMarkerConstants.CREATE_CATALYST_INSTANCE_END;
-import static com.facebook.react.bridge.ReactMarkerConstants.CREATE_CATALYST_INSTANCE_START;
-import static com.facebook.react.bridge.ReactMarkerConstants.CREATE_REACT_CONTEXT_START;
 import static com.facebook.react.bridge.ReactMarkerConstants.CREATE_VIEW_MANAGERS_END;
 import static com.facebook.react.bridge.ReactMarkerConstants.CREATE_VIEW_MANAGERS_START;
 import static com.facebook.react.bridge.ReactMarkerConstants.PRE_SETUP_REACT_CONTEXT_END;
@@ -49,9 +46,7 @@
 import com.facebook.infer.annotation.ThreadConfined;
 import com.facebook.infer.annotation.ThreadSafe;
 import com.facebook.react.bridge.Arguments;
-import com.facebook.react.bridge.BridgeReactContext;
 import com.facebook.react.bridge.CatalystInstance;
-import com.facebook.react.bridge.CatalystInstanceImpl;
 import com.facebook.react.bridge.JSBundleLoader;
 import com.facebook.react.bridge.JSExceptionHandler;
 import com.facebook.react.bridge.JavaScriptExecutor;
@@ -67,7 +62,6 @@
 import com.facebook.react.bridge.UIManagerProvider;
 import com.facebook.react.bridge.UiThreadUtil;
 import com.facebook.react.bridge.WritableNativeMap;
-import com.facebook.react.bridge.queue.ReactQueueConfigurationSpec;
 import com.facebook.react.common.LifecycleState;
 import com.facebook.react.common.ReactConstants;
 import com.facebook.react.common.SurfaceDelegateFactory;
@@ -86,8 +80,6 @@
 import com.facebook.react.internal.AndroidChoreographerProvider;
 import com.facebook.react.internal.ChoreographerProvider;
 import com.facebook.react.internal.featureflags.ReactNativeNewArchitectureFeatureFlags;
-import com.facebook.react.internal.turbomodule.core.TurboModuleManager;
-import com.facebook.react.internal.turbomodule.core.TurboModuleManagerDelegate;
 import com.facebook.react.modules.appearance.AppearanceModule;
 import com.facebook.react.modules.appregistry.AppRegistry;
 import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
@@ -1395,88 +1387,10 @@ private void tearDownReactContext(ReactContext reactContext) {
    */
   private ReactApplicationContext createReactContext(
       JavaScriptExecutor jsExecutor, JSBundleLoader jsBundleLoader) {
-
-    FLog.d(ReactConstants.TAG, "ReactInstanceManager.createReactContext()");
-    ReactMarker.logMarker(CREATE_REACT_CONTEXT_START, jsExecutor.getName());
-
-    final BridgeReactContext reactContext = new BridgeReactContext(mApplicationContext);
-
-    JSExceptionHandler exceptionHandler =
-        mJSExceptionHandler != null ? mJSExceptionHandler : mDevSupportManager;
-    reactContext.setJSExceptionHandler(exceptionHandler);
-
-    NativeModuleRegistry nativeModuleRegistry = processPackages(reactContext, mPackages);
-
-    CatalystInstanceImpl.Builder catalystInstanceBuilder =
-        new CatalystInstanceImpl.Builder()
-            .setReactQueueConfigurationSpec(ReactQueueConfigurationSpec.createDefault())
-            .setJSExecutor(jsExecutor)
-            .setRegistry(nativeModuleRegistry)
-            .setJSBundleLoader(jsBundleLoader)
-            .setJSExceptionHandler(exceptionHandler);
-
-    ReactMarker.logMarker(CREATE_CATALYST_INSTANCE_START);
-    // CREATE_CATALYST_INSTANCE_END is in JSCExecutor.cpp
-    Systrace.beginSection(TRACE_TAG_REACT, "createCatalystInstance");
-    final CatalystInstance catalystInstance;
-    try {
-      catalystInstance = catalystInstanceBuilder.build();
-    } finally {
-      Systrace.endSection(TRACE_TAG_REACT);
-      ReactMarker.logMarker(CREATE_CATALYST_INSTANCE_END);
-    }
-
-    reactContext.initializeWithInstance(catalystInstance);
-
-    // On Old Architecture, we need to initialize the Native Runtime Scheduler so that
-    // the `nativeRuntimeScheduler` object is registered on JS.
-    // On New Architecture, this is normally triggered by instantiate a TurboModuleManager.
-    // Here we invoke getRuntimeScheduler() to trigger the creation of it regardless of the
-    // architecture so it will always be there.
-    catalystInstance.getRuntimeScheduler();
-
-    if (ReactNativeNewArchitectureFeatureFlags.useTurboModules() && mTMMDelegateBuilder != null) {
-      TurboModuleManagerDelegate tmmDelegate =
-          mTMMDelegateBuilder
-              .setPackages(mPackages)
-              .setReactApplicationContext(reactContext)
-              .build();
-
-      TurboModuleManager turboModuleManager =
-          new TurboModuleManager(
-              catalystInstance.getRuntimeExecutor(),
-              tmmDelegate,
-              catalystInstance.getJSCallInvokerHolder(),
-              catalystInstance.getNativeMethodCallInvokerHolder());
-
-      catalystInstance.setTurboModuleRegistry(turboModuleManager);
-
-      // Eagerly initialize TurboModules
-      for (String moduleName : turboModuleManager.getEagerInitModuleNames()) {
-        turboModuleManager.getModule(moduleName);
-      }
-    }
-
-    if (mUIManagerProvider != null) {
-      UIManager uiManager = mUIManagerProvider.createUIManager(reactContext);
-      if (uiManager != null) {
-        catalystInstance.setFabricUIManager(uiManager);
-
-        // Initialize the UIManager
-        uiManager.initialize();
-        catalystInstance.setFabricUIManager(uiManager);
-      }
-    }
-    if (BuildConfig.ENABLE_PERFETTO || Systrace.isTracing(TRACE_TAG_REACT)) {
-      catalystInstance.setGlobalVariable("__RCTProfileIsProfiling", "true");
-    }
-
-    ReactMarker.logMarker(ReactMarkerConstants.PRE_RUN_JS_BUNDLE_START);
-    Systrace.beginSection(TRACE_TAG_REACT, "runJSBundle");
-    catalystInstance.runJSBundle();
-    Systrace.endSection(TRACE_TAG_REACT);
-
-    return reactContext;
+    // CatalystInstanceImpl has been removed as part of the Legacy Architecture cleanup.
+    throw new UnsupportedOperationException(
+        "ReactInstanceManager.createReactContext is unsupported. CatalystInstanceImpl has been"
+            + " removed.");
   }
 
   private NativeModuleRegistry processPackages(