Skip to content

Commit 1d3e7bf

Browse files
committed
Reposition layer sliders when settings are hidden
1 parent 279859b commit 1d3e7bf

2 files changed

Lines changed: 41 additions & 5 deletions

File tree

resources/qml/SidebarStageMenu.qml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ Item
2222
property bool isLE46
2323

2424
property bool preSlicedData: PrintInformation !== null && PrintInformation.preSliced
25-
property bool sidebarVisible: UM.Preferences.getValue("view/settings_visible") && !preSlicedData
25+
property bool settingsVisible: UM.Preferences.getValue("view/settings_visible")
26+
property bool sidebarVisible: settingsVisible && !preSlicedData
2627
property real sidebarWidth: sidebarVisible ? printSetupSelector.width : 0
2728

2829
Component.onCompleted:
@@ -148,15 +149,15 @@ Item
148149
{
149150
if (preference == "view/settings_visible")
150151
{
151-
sidebarVisible = UM.Preferences.getValue("view/settings_visible") && !preSlicedData
152+
settingsVisible = UM.Preferences.getValue("view/settings_visible")
152153
base.onWidthChanged(base.width)
153154
}
154155
}
155156
}
156157

157158
onPreSlicedDataChanged:
158159
{
159-
sidebarVisible = UM.Preferences.getValue("view/settings_visible") && !preSlicedData
160+
settingsVisible = UM.Preferences.getValue("view/settings_visible")
160161
base.onWidthChanged(base.width)
161162
}
162163

resources/qml/StageMain.qml

Lines changed: 37 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,35 @@ Loader
1111
id: loader
1212
source: UM.Controller.activeView != null && UM.Controller.activeView.mainComponent != null ? UM.Controller.activeView.mainComponent : ""
1313

14+
property bool preSlicedData: PrintInformation !== null && PrintInformation.preSliced
15+
property bool settingsVisible: UM.Preferences.getValue("view/settings_visible")
16+
property bool sidebarVisible: settingsVisible && !preSlicedData
17+
1418
onLoaded:
1519
{
1620
var viewString = UM.Controller.activeView + "";
1721
var activeView = viewString.substr(0, viewString.indexOf("("));
1822
if(activeView == "SimulationView")
1923
{
24+
var sidebarFooter = stageMenu.item.children[5];
25+
2026
var pathSlider = item.children[0];
2127
pathSlider.anchors.horizontalCenter = undefined;
2228
pathSlider.anchors.right = pathSlider.parent.right;
23-
pathSlider.anchors.rightMargin = UM.Theme.getSize("print_setup_widget").width + UM.Theme.getSize("default_margin").width;
29+
pathSlider.anchors.rightMargin = Qt.binding(function()
30+
{
31+
if(sidebarVisible)
32+
return UM.Theme.getSize("print_setup_widget").width + UM.Theme.getSize("default_margin").width;
33+
else
34+
return UM.Theme.getSize("default_margin").width;
35+
});
36+
pathSlider.anchors.bottomMargin = Qt.binding(function()
37+
{
38+
if(sidebarVisible)
39+
return UM.Theme.getSize("default_margin").height;
40+
else
41+
return sidebarFooter.height + UM.Theme.getSize("default_margin").height
42+
});
2443

2544
var layerSlider = item.children[2];
2645
layerSlider.anchors.right = pathSlider.right;
@@ -31,11 +50,27 @@ Loader
3150
layerSlider.anchors.bottomMargin = UM.Theme.getSize("default_margin").height;
3251
layerSlider.height = Qt.binding(function()
3352
{
53+
var unavailableHeight = (stageMenu.item.children[2].height + pathSlider.height + 5 * UM.Theme.getSize("default_margin").height);
54+
if(!sidebarVisible)
55+
unavailableHeight = (sidebarFooter.height + stageMenu.item.children[3].height + pathSlider.height + 3 * UM.Theme.getSize("default_margin").height)
56+
3457
return Math.min(
3558
UM.Theme.getSize("slider_layerview_size").height,
36-
contentItem.height - (stageMenu.item.children[2].height + pathSlider.height + 5 * UM.Theme.getSize("default_margin").height)
59+
contentItem.height - unavailableHeight
3760
);
3861
})
3962
}
4063
}
64+
65+
Connections
66+
{
67+
target: UM.Preferences
68+
onPreferenceChanged:
69+
{
70+
if (preference == "view/settings_visible")
71+
{
72+
settingsVisible = UM.Preferences.getValue("view/settings_visible")
73+
}
74+
}
75+
}
4176
}

0 commit comments

Comments
 (0)