Skip to content

Commit 42ff080

Browse files
committed
Fix binding loop
1 parent 779e5dd commit 42ff080

2 files changed

Lines changed: 16 additions & 6 deletions

File tree

resources/qml/MonitorStageMenu.qml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ Item
6868
anchors.rightMargin: UM.Theme.getSize("print_setup_widget").width - width
6969
y: - Math.floor((UM.Theme.getSize("main_window_header").height + height) / 2)
7070

71-
Component.onCompleted: {
71+
Component.onCompleted:
72+
{
7273
machineSelection.children[1].visible = false // remove shadow
7374
if(isLE46) {
7475
var machineSelectionHeader = machineSelection.children[0].children[3].children[0]

resources/qml/ViewOptionsPanel.qml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,17 @@ Rectangle
134134
}
135135
return "PrepareStageLegend.qml";
136136
}
137+
138+
onLoaded:
139+
{
140+
legendHeaderItem.children = [
141+
viewMenuComponent.item.contentItem.children[0],
142+
viewMenuComponent.item.contentItem.children[1]
143+
]
144+
legendItems.children = [
145+
viewMenuComponent.item.contentItem
146+
]
147+
}
137148
}
138149

139150
Item
@@ -153,11 +164,9 @@ Rectangle
153164
right: legendCollapseButton.left
154165
rightMargin: UM.Theme.getSize("default_margin").width
155166
}
156-
children: [
157-
viewMenuComponent.item.contentItem.children[0],
158-
viewMenuComponent.item.contentItem.children[1]
159-
]
160167
height: childrenRect.height
168+
169+
// populated by viewMenuComponent
161170
}
162171

163172
UM.SimpleButton
@@ -187,7 +196,7 @@ Rectangle
187196
id: legendItems
188197
visible: UM.Preferences.getValue("sidebargui/expand_legend")
189198

190-
children: [viewMenuComponent.item.contentItem]
199+
// populated by viewMenuComponent
191200
}
192201
}
193202

0 commit comments

Comments
 (0)