feat: permanent errors for chunk test requests

#35

Author: AidasK

src/flow.js

@@ -1153,11 +1153,16 @@
      */
     this.testHandler = function(event) {
       var status = $.status();
-      if (status === 'success') {
+      if (status === 'error') {
+        $.event(status, $.message());
+        $.flowObj.uploadNextChunk();
+      } else if (status === 'success') {
         $.tested = true;
-        $.fileObj.chunkEvent(status, $.message());
+        $.event(status, $.message());
         $.flowObj.uploadNextChunk();
-      } else if (!$.fileObj.paused) {// Error might be caused by file pause method
+      } else if (!$.fileObj.paused) {
+        // Error might be caused by file pause method
+        // Chunks does not exist on the server side
         $.tested = true;
         $.send();
       }
@@ -1321,7 +1326,7 @@
 		      // HTTP 202 Accepted - The request has been accepted for processing, but the processing has not been completed.
           return 'success';
         } else if (this.flowObj.opts.permanentErrors.indexOf(this.xhr.status) > -1 ||
-            this.retries >= this.flowObj.opts.maxChunkRetries) {
+            this.retries && this.retries >= this.flowObj.opts.maxChunkRetries) {
           // HTTP 415/500/501, permanent error
           return 'error';
         } else {

test/uploadSpec.js

@@ -331,6 +331,30 @@ describe('upload file', function() {
     expect(success).not.toHaveBeenCalled();
   });
 
+  it('should fail on permanent test error', function () {
+    flow.opts.testChunks = true;
+    flow.opts.chunkSize = 1;
+    flow.opts.simultaneousUploads = 2;
+    flow.opts.maxChunkRetries = 1;
+    flow.opts.permanentErrors = [500];
+
+    var error = jasmine.createSpy('error');
+    var success = jasmine.createSpy('success');
+    var retry = jasmine.createSpy('retry');
+    flow.on('fileError', error);
+    flow.on('fileSuccess', success);
+    flow.on('fileRetry', retry);
+
+    flow.addFile(new Blob(['abc']));
+    flow.upload();
+    expect(requests.length).toBe(2);
+    requests[0].respond(500);
+    expect(requests.length).toBe(2);
+    expect(error).toHaveBeenCalled();
+    expect(retry).not.toHaveBeenCalled();
+    expect(success).not.toHaveBeenCalled();
+  });
+
   it('should upload empty file', function () {
     var error = jasmine.createSpy('error');
     var success = jasmine.createSpy('success');
@@ -390,8 +414,6 @@ describe('upload file', function() {
     expect(error).not.toHaveBeenCalled();
   });
 
-
-
   it('should preprocess chunks and wait for preprocess to finish', function () {
     flow.opts.simultaneousUploads = 1;
     var preprocess = jasmine.createSpy('preprocess');