Skip to content

Commit 5035087

Browse files
@W-21933885: [MSDK Android] App Attestation Implementation (Light Automated Code Review Updates)
1 parent 9a2aca8 commit 5035087

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

libs/SalesforceSDK/src/com/salesforce/androidsdk/auth/AppAttestationClient.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,6 @@ class AppAttestationClient(
206206
* @param appAttestationChallenge The Salesforce Mobile App Attestation
207207
* External Client App (ECA) Plug-In "Challenge" to use
208208
*/
209-
@JvmName("createAppAttestationBlocking")
210209
fun createAppAttestationBlocking(appAttestationChallenge: String) = runBlocking {
211210
createAppAttestation(appAttestationChallenge)
212211
}

libs/SalesforceSDK/src/com/salesforce/androidsdk/auth/NativeLoginManager.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ internal class NativeLoginManager(
181181
val authRequest = RestRequest(
182182
POST,
183183
LOGIN,
184-
"$loginUrl$OAUTH_AUTH_PATH${attestationValue?.let { "?$ATTESTATION=$it" } ?: ""}", // Full path for unauthenticated request
184+
"$loginUrl$OAUTH_AUTH_PATH${attestationValue?.let { "?$ATTESTATION=${Uri.encode(it)}" } ?: ""}", // Full path for unauthenticated request
185185
authRequestBody,
186186
authRequestHeaders,
187187
)

libs/SalesforceSDK/src/com/salesforce/androidsdk/auth/OAuth2.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131

3232
import androidx.annotation.NonNull;
3333
import androidx.annotation.VisibleForTesting;
34+
import androidx.annotation.WorkerThread;
3435

3536
import com.salesforce.androidsdk.app.SalesforceSDKManager;
3637
import com.salesforce.androidsdk.rest.RestResponse;
@@ -567,6 +568,7 @@ public static Request.Builder addAuthorizationHeader(Request.Builder builder, St
567568
}
568569

569570
@VisibleForTesting
571+
@WorkerThread
570572
public static TokenEndpointResponse makeTokenEndpointRequest(HttpAccess httpAccessor,
571573
URI loginServer,
572574
FormBody.Builder formBodyBuilder,

0 commit comments

Comments
 (0)