@W-21933885: [MSDK Android] App Attestation Implementation (NativeLoginManager.login Code Coverage Test)

JohnsonEricAtSalesforce · JohnsonEricAtSalesforce · commit 55d370fa9104 · 2026-04-24T12:57:50.000-06:00
diff --git a/libs/SalesforceSDK/src/com/salesforce/androidsdk/auth/NativeLoginManager.kt b/libs/SalesforceSDK/src/com/salesforce/androidsdk/auth/NativeLoginManager.kt
@@ -179,10 +179,11 @@ internal class NativeLoginManager(
             REDIRECT_URI to redirectUri,
             CODE_CHALLENGE to codeChallenge,
         )
+        val queryString = attestationValue?.let { "?$ATTESTATION=${it}" } ?: ""
         val authRequest = RestRequest(
             POST,
             LOGIN,
-            "$loginUrl$OAUTH_AUTH_PATH${attestationValue?.let { "?$ATTESTATION=${it}" } ?: ""}", // Full path for unauthenticated request
+            "$loginUrl$OAUTH_AUTH_PATH$queryString", // Full path for unauthenticated request
             authRequestBody,
             authRequestHeaders,
         )

Original file line number	Diff line number	Diff line change
`@@ -179,10 +179,11 @@ internal class NativeLoginManager(`
`179`	`179`	`REDIRECT_URI to redirectUri,`
`180`	`180`	`CODE_CHALLENGE to codeChallenge,`
`181`	`181`	`)`
	`182`	`+ val queryString = attestationValue?.let { "?$ATTESTATION=${it}" } ?: ""`
`182`	`183`	`val authRequest = RestRequest(`
`183`	`184`	`POST,`
`184`	`185`	`LOGIN,`
`185`		`- "$loginUrl$OAUTH_AUTH_PATH${attestationValue?.let { "?$ATTESTATION=${it}" } ?: ""}", // Full path for unauthenticated request`
	`186`	`+ "$loginUrl$OAUTH_AUTH_PATH$queryString", // Full path for unauthenticated request`
`186`	`187`	`authRequestBody,`
`187`	`188`	`authRequestHeaders,`
`188`	`189`	`)`