Remove Deprecated Code. (#2689)

Remove deprecated code.

Author: brandonpage

libs/SalesforceHybrid/src/com/salesforce/androidsdk/phonegap/ui/SalesforceDroidGapActivity.kt

@@ -521,52 +521,6 @@ open class SalesforceDroidGapActivity : CordovaActivity(), SalesforceActivityInt
         webAppLoaded = true
     }
 
-    /**
-     * Returns the front-doored URL of a URL passed in.
-     *
-     * @param providedUrl URL to be front-doored
-     * @param isAbsoluteUrl True if the URL should be used as is; false
-     * otherwise
-     * @return The front-doored URL
-     *
-     * @Deprecated we are no longer using front door to setup the session in the web view
-     *             instead we get the session from the login/refresh oauth flow
-     *             and sets them in CookieManager using SalesforceWebViewCookieManager
-     *             This method will be remove in Mobile SDK 13.0
-     */
-    @Deprecated("Deprecated - to be removed in 13.0")
-    fun getFrontDoorUrl(
-        providedUrl: String?,
-        isAbsoluteUrl: Boolean
-    ): String? {
-
-        /*
-         * Use the absolute URL in some cases and the relative URL in some other
-         * cases because of differences between instance URL and community URL.
-         * Community URL can be custom and the logic of determining which URL to
-         * use is in the 'resolveUrl' method in 'ClientInfo'
-         */
-        val restClient = restClient ?: return null
-        return "${restClient.clientInfo.instanceUrlAsString}/secur/frontdoor.jsp?".toHttpUrlOrNull()
-            ?.newBuilder()
-            ?.addQueryParameter(
-                name = "sid",
-                value = restClient.authToken
-            )
-            ?.addQueryParameter(
-                name = "retURL",
-                value = when {
-                    isAbsoluteUrl -> providedUrl
-                    else -> restClient.clientInfo.resolveUrl(providedUrl).toString()
-                }
-            )
-            ?.addQueryParameter(
-                name = "display",
-                value = "touch"
-            )
-            ?.build().toString()
-    }
-
     /**
      * Load cached start page
      */

libs/SalesforceSDK/src/com/salesforce/androidsdk/analytics/SalesforceAnalyticsManager.java

@@ -208,19 +208,6 @@ public static synchronized void setPublishPeriodicallyFrequencyHours(
         setAnalyticsPublishingType(PublishPeriodically);
     }
 
-    /**
-     * Sets the interval for periodic background publishing in hours.
-     *
-     * @deprecated Planned for removal 13.0.
-     * Use {@link #setPublishPeriodicallyFrequencyHours(int)} )}.
-     */
-    @Deprecated()
-    public static synchronized void setPublishFrequencyInHours(
-            int periodicBackgroundPublishingHoursInterval
-    ) {
-        setPublishPeriodicallyFrequencyHours(periodicBackgroundPublishingHoursInterval);
-    }
-
     /**
      * The enabled Salesforce analytics publishing type.
      *
@@ -263,19 +250,6 @@ public static int getPublishPeriodicallyFrequencyHours() {
         return publishPeriodicallyFrequencyHours;
     }
 
-    /**
-     * Returns the publish frequency currently set, in hours.
-     *
-     * @return Publish frequency, in hours.
-     * @noinspection unused
-     * @deprecated Planned for removal 13.0.
-     * Use {@link #getPublishPeriodicallyFrequencyHours()} )}.
-     */
-    @Deprecated
-    public static int getPublishFrequencyInHours() {
-        return getPublishPeriodicallyFrequencyHours();
-    }
-
     /**
      * Returns an instance of event store manager.
      *

libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/SalesforceActivityDelegate.java

@@ -144,9 +144,6 @@ protected void onUserSwitch() {
      */
     private class ActivityLogoutCompleteReceiver extends LogoutCompleteReceiver {
 
-        @Override
-        protected void onLogoutComplete() { }
-
         @Override
         protected void onLogoutComplete(@NonNull OAuth2.LogoutReason reason) {
             ((SalesforceActivityInterface) activity).onLogoutComplete();

libs/SalesforceSDK/src/com/salesforce/androidsdk/util/LogoutCompleteReceiver.kt

@@ -39,16 +39,10 @@ import java.util.Locale
 abstract class LogoutCompleteReceiver : BroadcastReceiver() {
     override fun onReceive(context: Context, intent: Intent) {
         if (intent.action == SalesforceSDKManager.LOGOUT_COMPLETE_INTENT_ACTION) {
-            onLogoutComplete()
-
             val reason = intent.getStringExtra(SalesforceSDKManager.LOGOUT_REASON_KEY) ?: LogoutReason.UNKNOWN.toString()
             onLogoutComplete(LogoutReason.valueOf(reason.uppercase(Locale.ROOT)))
         }
     }
 
-    /** @deprecated Will be removed in 13.0.  Use the new [onLogoutComplete] that provides a [LogoutReason] instead. */
-    protected abstract fun onLogoutComplete()
-
-    // TODO: Make this abstract in 13.0 to replace the above onLogoutComplete()
-    protected open fun onLogoutComplete(reason: LogoutReason) { }
-}
+    protected abstract fun onLogoutComplete(reason: LogoutReason)
+}