@W-21933885: [MSDK Android] App Attestation Implementation (Fix TokenMigrationActivityTest By Using mockkObject With Explicit Lifecycle Stubs)

Author: JohnsonEricAtSalesforce

libs/test/SalesforceSDKTest/src/com/salesforce/androidsdk/ui/TokenMigrationActivityTest.kt

@@ -82,7 +82,6 @@ class TokenMigrationActivityTest {
     private lateinit var mockClientManager: com.salesforce.androidsdk.rest.ClientManager
     private lateinit var realSdkManager: SalesforceSDKManager
     private lateinit var savedFactory: ViewModelProvider.Factory
-    private var savedAppAttestationClient: AppAttestationClient? = null
 
     @Before
     fun setUp() {
@@ -116,20 +115,34 @@ class TokenMigrationActivityTest {
         // Get the REAL SalesforceSDKManager instance and save reference + properties
         realSdkManager = SalesforceSDKManager.getInstance()
         savedFactory = realSdkManager.loginViewModelFactory
-        savedAppAttestationClient = realSdkManager.appAttestationClient
 
-        // CRITICAL: Set appAttestationClient to null on the REAL instance to prevent blocking network calls
-        // This must be done before creating the spy to ensure the spy sees the null value
-        realSdkManager.appAttestationClient = null
+        // Mock the SalesforceSDKManager object to control specific properties
+        mockkObject(SalesforceSDKManager)
 
-        // Mock only the clientManager on the real instance using spyk
-        val sdkManagerSpy = spyk(realSdkManager)
-        every { sdkManagerSpy.clientManager } returns mockClientManager
+        // Mock appContext for logging
+        every { SalesforceSDKManager.getInstance().appContext } returns getApplicationContext()
+
+        // Mock userAccountManager (called during lifecycle for biometric auth checks)
+        every { SalesforceSDKManager.getInstance().userAccountManager } returns mockUserAccountManager
+
+        // CRITICAL: Mock appAttestationClient to return null to prevent blocking network calls
+        // in LoginViewModel.getAuthorizationUrl() and OAuth2.makeTokenEndpointRequest()
+        every { SalesforceSDKManager.getInstance().appAttestationClient } returns null
+
+        // Mock clientManager to return our mock
+        every { SalesforceSDKManager.getInstance().clientManager } returns mockClientManager
         every { mockClientManager.peekRestClient(any<UserAccount>()) } returns mockRestClient
 
-        // Replace getInstance() to return our spy instead of completely mocking the object
-        mockkStatic(SalesforceSDKManager::class)
-        every { SalesforceSDKManager.getInstance() } returns sdkManagerSpy
+        // Allow tests to set loginViewModelFactory
+        every { SalesforceSDKManager.getInstance().loginViewModelFactory = any() } answers { }
+        every { SalesforceSDKManager.getInstance().loginViewModelFactory } returns savedFactory
+
+        // Mock push notification receiver (called during lifecycle for push setup)
+        every { SalesforceSDKManager.getInstance().pushNotificationReceiver } returns null
+
+        // Allow lifecycle methods to be called without errors
+        every { SalesforceSDKManager.getInstance().isDevSupportEnabled() } returns false
+        every { SalesforceSDKManager.getInstance().onResume(any()) } returns Unit
 
         // Default mock for sendSync to prevent hanging - tests can override this
         val mockResponse = mockk<com.salesforce.androidsdk.rest.RestResponse>(relaxed = true)
@@ -144,10 +157,13 @@ class TokenMigrationActivityTest {
 
     @After
     fun tearDown() {
-        // Restore the loginViewModelFactory and appAttestationClient on the REAL instance (not via getInstance())
+        // Restore the loginViewModelFactory on the REAL instance (not via getInstance())
         // This must be done before unmockkAll() so we have the reference
         realSdkManager.loginViewModelFactory = savedFactory
-        realSdkManager.appAttestationClient = savedAppAttestationClient
+
+        // NOTE: We don't save/restore appAttestationClient because the setter is internal and not
+        // accessible from test module. The unmockkAll() below clears all mocking, reverting
+        // the mocked SalesforceSDKManager object back to normal behavior.
 
         // Clean up all mocks
         unmockkAll()