@W-21933885: [MSDK Android] App Attestation Implementation (Increase Test Code Coverage For AppAttestationChallengeApiClient)

Author: JohnsonEricAtSalesforce

libs/SalesforceSDK/src/com/salesforce/androidsdk/rest/AppAttestationChallengeApiClient.kt

@@ -68,9 +68,11 @@ internal class AppAttestationChallengeApiClient(
         )
         val restResponse = restClient.sendSync(restRequest)
         val responseBodyString = restResponse.asString()
+        // TODO: Needs Coverage. ECJ20260416
         return if (restResponse.isSuccess && responseBodyString != null) {
             responseBodyString
         } else {
+            // TODO: Needs Coverage. ECJ20260416
             throw AppAttestationChallengeApiException(
                 source = responseBodyString
             )

libs/SalesforceSDK/src/com/salesforce/androidsdk/rest/AppAttestationChallengeApiException.kt

@@ -34,6 +34,7 @@ package com.salesforce.androidsdk.rest
  * @param source The original Salesforce Mobile App Attestation Challenge API
  * error response body
  */
+// TODO: Needs Coverage. ECJ20260416
 class AppAttestationChallengeApiException(
-    val source: String
+    val source: String?
 ) : Exception()

libs/test/SalesforceSDKTest/src/com/salesforce/androidsdk/auth/AppAttestationChallengeApiClientTest.kt

@@ -0,0 +1,108 @@
+/*
+ * Copyright (c) 2026-present, salesforce.com, inc.
+ * All rights reserved.
+ * Redistribution and use of this software in source and binary forms, with or
+ * without modification, are permitted provided that the following conditions
+ * are met:
+ * - Redistributions of source code must retain the above copyright notice, this
+ * list of conditions and the following disclaimer.
+ * - Redistributions in binary form must reproduce the above copyright notice,
+ * this list of conditions and the following disclaimer in the documentation
+ * and/or other materials provided with the distribution.
+ * - Neither the name of salesforce.com, inc. nor the names of its contributors
+ * may be used to endorse or promote products derived from this software without
+ * specific prior written permission of salesforce.com, inc.
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+package com.salesforce.androidsdk.auth
+
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.salesforce.androidsdk.rest.AppAttestationChallengeApiClient
+import com.salesforce.androidsdk.rest.AppAttestationChallengeApiException
+import com.salesforce.androidsdk.rest.RestClient
+import com.salesforce.androidsdk.rest.RestResponse
+import io.mockk.every
+import io.mockk.mockk
+import org.junit.Assert.assertThrows
+import org.junit.Test
+import org.junit.runner.RunWith
+
+@RunWith(AndroidJUnit4::class)
+class AppAttestationChallengeApiClientTest {
+
+    @Test
+    fun appAttestationChallengeApiClient_fetchChallenge_throwsWhenRestResponseIsNotSuccess() {
+
+        val restResponse = mockk<RestResponse>(relaxed = true)
+        every { restResponse.asString() } returns "__TEST_CHALLENGE_VALUE__"
+        every { restResponse.isSuccess } returns false
+        val restClient = mockk<RestClient>(relaxed = true)
+        every { restClient.sendSync(any()) } returns restResponse
+
+        val appAttestationChallengeApiClient = AppAttestationChallengeApiClient(
+            apiHostName = "https://www.example.com",
+            restClient = restClient
+        )
+
+        assertThrows(AppAttestationChallengeApiException::class.java) {
+            appAttestationChallengeApiClient.fetchChallenge(
+                attestationId = "__ATTESTATION_ID__",
+                remoteConsumerKey = "__REMOTE_CONSUMER_KEY__"
+            )
+        }
+    }
+
+    @Test
+    fun appAttestationChallengeApiClient_fetchChallenge_throwsWhenRestResponseBodyStringIsNull() {
+
+        val restResponse = mockk<RestResponse>(relaxed = true)
+        every { restResponse.asString() } returns null
+        every { restResponse.isSuccess } returns true
+        val restClient = mockk<RestClient>(relaxed = true)
+        every { restClient.sendSync(any()) } returns restResponse
+
+        val appAttestationChallengeApiClient = AppAttestationChallengeApiClient(
+            apiHostName = "https://www.example.com",
+            restClient = restClient
+        )
+
+        assertThrows(AppAttestationChallengeApiException::class.java) {
+            appAttestationChallengeApiClient.fetchChallenge(
+                attestationId = "__ATTESTATION_ID__",
+                remoteConsumerKey = "__REMOTE_CONSUMER_KEY__"
+            )
+        }
+    }
+
+    @Test
+    fun appAttestationChallengeApiClient_fetchChallenge_throwsWhenRestResponseIsNotSuccessAndBodyStringIsNull() {
+
+        val restResponse = mockk<RestResponse>(relaxed = true)
+        every { restResponse.asString() } returns null
+        every { restResponse.isSuccess } returns false
+        val restClient = mockk<RestClient>(relaxed = true)
+        every { restClient.sendSync(any()) } returns restResponse
+
+        val appAttestationChallengeApiClient = AppAttestationChallengeApiClient(
+            apiHostName = "https://www.example.com",
+            restClient = restClient
+        )
+
+        assertThrows(AppAttestationChallengeApiException::class.java) {
+            appAttestationChallengeApiClient.fetchChallenge(
+                attestationId = "__ATTESTATION_ID__",
+                remoteConsumerKey = "__REMOTE_CONSUMER_KEY__"
+            )
+        }
+    }
+}